Issue 6428076: cmd/juju: status: workaround json limitations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6428076: cmd/juju: status: workaround json limitations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dave

Modified:
11 years, 9 months ago

Reviewers:
mp+116495

Visibility:
Public.

Description

cmd/juju: status: workaround json limitations This proposal allows keys for the machines map to be ints, while retaining compatibility with encoding/json. It adds some ugliness; but has a cute function name. https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-juju-status-yaml-json-fix/+merge/116495 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: status: workaround json limitations #

Patch Set 3 : cmd/juju: status: workaround json limitations #

Patch Set 4 : cmd/juju: status: workaround json limitations #

Patch Set 5 : cmd/juju: status: workaround json limitations #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -26 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
A	cmd/juju/export_test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	cmd/juju/status.go	View	1 2	5 chunks	+27 lines, -18 lines	0 comments	Download
M	cmd/juju/status_test.go	View	1 2 3	4 chunks	+12 lines, -8 lines	0 comments	Download
M	cmd/output.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

11 years, 9 months ago (2012-07-25 09:46:25 UTC) #5

*** Submitted:

cmd/juju: status: workaround json limitations

This proposal allows keys for the machines map to be ints, while
retaining compatibility with encoding/json.

It adds some ugliness; but has a cute function name.

R=niemeyer
CC=
https://codereview.appspot.com/6428076

Expand All Messages | Collapse All Messages