Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 6423062: schema: introduce StringMap; kill MapType and ListType

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by niemeyer
Modified:
12 years, 8 months ago
Reviewers:
mp+115849, fwereade
Visibility:
Public.

Description

schema: introduce StringMap; kill MapType and ListType This makes it a lot more pleasant to deal with map[string]interface{} types, which is by far our most dominant use of schema. https://code.launchpad.net/~niemeyer/juju-core/schema-string-map/+merge/115849 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : schema: introduce StringMap; kill MapType and ListType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -59 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charm/config.go View 3 chunks +5 lines, -5 lines 0 comments Download
M charm/meta.go View 6 chunks +11 lines, -11 lines 0 comments Download
M charm/meta_test.go View 2 chunks +16 lines, -17 lines 0 comments Download
M environs/config/config.go View 1 chunk +1 line, -4 lines 0 comments Download
M environs/dummy/environs.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/ec2/config.go View 1 chunk +1 line, -1 line 0 comments Download
M schema/schema.go View 9 chunks +49 lines, -13 lines 0 comments Download
M schema/schema_test.go View 6 chunks +36 lines, -7 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
12 years, 8 months ago (2012-07-19 22:34:12 UTC) #1
fwereade
LGTM https://codereview.appspot.com/6423062/diff/1/charm/meta.go File charm/meta.go (right): https://codereview.appspot.com/6423062/diff/1/charm/meta.go#newcode159 charm/meta.go:159: // defaults, which is different than what FieldMap ...
12 years, 8 months ago (2012-07-19 22:45:02 UTC) #2
niemeyer
12 years, 8 months ago (2012-07-20 00:02:28 UTC) #3
*** Submitted:

schema: introduce StringMap; kill MapType and ListType

This makes it a lot more pleasant to deal with map[string]interface{}
types, which is by far our most dominant use of schema.

R=fwereade
CC=
https://codereview.appspot.com/6423062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b