Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6423043: cmd/juju: status: various improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by dave
Modified:
12 years, 8 months ago
Reviewers:
mp+115460
Visibility:
Public.

Description

cmd/juju: status: various improvements * Added reporting of agent-status and proposed-agent-status * Improved error handling ** Where sensible, some fields are omitted if they could not be retrieved ** Where not possible, errors are reported in a status-error field. * Add basic support for units, and some cleanups. Encompases https://codereview.appspot.com/6449056/ and https://codereview.appspot.com/6452056/ which were unsubmittable due to a broken prereq chain https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-juju-status/+merge/115460 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: initial status command #

Patch Set 3 : cmd/juju: initial status command #

Total comments: 4

Patch Set 4 : cmd/juju: initial status command #

Patch Set 5 : cmd/juju: status: various improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -49 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/status.go View 1 2 3 4 4 chunks +85 lines, -30 lines 0 comments Download
M cmd/juju/status_test.go View 1 2 3 4 4 chunks +188 lines, -19 lines 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Please take a look.
12 years, 8 months ago (2012-07-18 01:25:47 UTC) #1
dave_cheney.net
Please take a look.
12 years, 8 months ago (2012-07-18 21:50:42 UTC) #2
niemeyer
LGTM https://codereview.appspot.com/6423043/diff/5001/cmd/juju/status.go File cmd/juju/status.go (right): https://codereview.appspot.com/6423043/diff/5001/cmd/juju/status.go#newcode15 cmd/juju/status.go:15: entities. I think the documentation can end here. ...
12 years, 8 months ago (2012-07-18 22:17:48 UTC) #3
dave_cheney.net
*** Submitted: cmd/juju: initial status command Nothing really notable here, just the outline of the ...
12 years, 8 months ago (2012-07-18 22:26:42 UTC) #4
dave_cheney.net
12 years, 8 months ago (2012-08-03 02:38:03 UTC) #5
Oh for fracks sake. I've accidentally reused the _name_ of a previous branch, so
now this has overwritten a subtmitted CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b