Issue 6422058: juju: add NewConnFromAttrs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6422058: juju: add NewConnFromAttrs.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
mp+116284

Visibility:
Public.

Description

juju: add NewConnFromAttrs. It's useful for testing Conns, apart from anything else. https://code.launchpad.net/~rogpeppe/juju-core/juju-newconnfromattrs/+merge/116284 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: add NewConnFromAttrs. #

Patch Set 3 : juju: add NewConnFromAttrs. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/conn.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	juju/conn_test.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TheMue

On 2012/07/23 13:40:09, rog wrote: > Please take a look. LGTM

11 years, 9 months ago (2012-07-23 14:52:13 UTC) #2

rog

11 years, 9 months ago (2012-07-24 15:17:07 UTC) #4

*** Submitted:

juju: add NewConnFromAttrs.

It's useful for testing Conns, apart from anything else.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6422058

Expand All Messages | Collapse All Messages