Issue 6421045: environs: inherit environment variables when building tools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6421045: environs: inherit environment variables when building tools

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by rog

Modified:
12 years, 8 months ago

Reviewers:
mp+115668

Visibility:
Public.

Description

environs: inherit environment variables when building tools Unknown environment variables can have an effect on whether the tools build. William encountered an error from cgo which was fixed by this patch. https://code.launchpad.net/~rogpeppe/juju-core/go-build-env/+merge/115668 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: inherit environment variables when building tools #

Patch Set 3 : environs: inherit environment variables when building tools #

Total comments: 1

Patch Set 4 : environs: inherit environment variables when building tools #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -5 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	environs/export_test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	environs/tools.go	View		2 chunks	+12 lines, -5 lines	0 comments	Download
M	environs/tools_test.go	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

fwereade

On 2012/07/19 09:05:10, rog wrote: > Please take a look. LGTM

12 years, 8 months ago (2012-07-19 09:06:50 UTC) #2

niemeyer

https://codereview.appspot.com/6421045/diff/5001/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6421045/diff/5001/environs/tools.go#newcode272 environs/tools.go:272: cmd.Env = setenv(os.Environ(), "GOBIN="+dir) s/setenv/append/ should be enough.

12 years, 8 months ago (2012-07-19 12:38:52 UTC) #4

niemeyer

As rog pointed out on IRC, append isn't guaranteed to work, so LGTM too.

12 years, 8 months ago (2012-07-19 17:55:43 UTC) #5

rog

12 years, 8 months ago (2012-07-19 18:39:04 UTC) #6

*** Submitted:

environs: inherit environment variables when building tools

Unknown environment variables can have an effect on
whether the tools build. William encountered an error
from cgo which was fixed by this patch.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6421045

Expand All Messages | Collapse All Messages