Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7706)

Issue 6420046: Fix always true condition in assert in MacroExpander.cpp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by mvujovic
Modified:
11 years, 9 months ago
Reviewers:
Alok Priyadarshi
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix always true condition in assert in MacroExpander.cpp. context->index is a size_t, so it's always >= 0. Let's check that it's > 0 before we decrement it. Issue: http://code.google.com/p/angleproject/issues/detail?id=349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/preprocessor/new/MacroExpander.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/MacroExpander.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mvujovic
Hi Alok, Could you look at this when you get a chance? Thanks, Max
11 years, 9 months ago (2012-07-18 17:08:06 UTC) #1
Alok Priyadarshi
lgtm. Thanks.
11 years, 9 months ago (2012-07-18 17:17:57 UTC) #2
mvujovic
11 years, 9 months ago (2012-07-18 17:31:43 UTC) #3
On 2012/07/18 17:17:57, Alok Priyadarshi wrote:
> lgtm. Thanks.

Thanks, Alok. Committed in r1228.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b