Issue 6408045: ConfigNode only writes to ZK when it should

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6408045: ConfigNode only writes to ZK when it should

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by fwereade

Modified:
11 years, 9 months ago

Reviewers:
mp+115022

Visibility:
Public.

Description

ConfigNode only writes to ZK when it should Beforehand, when calling Write without changes, its behaviour was dependent on the (essentially random :/) yaml serialization. So, *usually*, it would do the right thing; but sometimes it'd rewrite the node for no good reason and cause entirely surprising failures at a distance. https://code.launchpad.net/~fwereade/juju-core/config-node-bug/+merge/115022 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ConfigNode only writes to ZK when it should #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/confignode.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	state/confignode_test.go	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2012/07/15 08:50:35, fwereade wrote: > Please take a look. LGTM

11 years, 9 months ago (2012-07-16 08:44:41 UTC) #2

fwereade

11 years, 9 months ago (2012-07-16 08:59:24 UTC) #4

*** Submitted:

ConfigNode only writes to ZK when it should

Beforehand, when calling Write without changes, its behaviour was
dependent on the (essentially random :/) yaml serialization. So,
*usually*, it would do the right thing; but sometimes it'd rewrite
the node for no good reason and cause entirely surprising failures
at a distance.

R=rog, TheMue
CC=
https://codereview.appspot.com/6408045

Expand All Messages | Collapse All Messages