Don't leave empty source*map files sitting around.

Don't leave empty source*map files sitting around.

[imirkin_alum.mit.edu, 2012-07-15 18:52:47]

I was also considering putting an explicit delete in
Compilation.compile() but that seems too unexpected, and potentially
buggy in the future.

On Sun, Jul 15, 2012 at 2:47 PM,  <ibmirkin@gmail.com> wrote:
> Reviewers: bolinfest,
>
> Description:
> Don't leave empty source*map files sitting around.
>
> Please review this at http://codereview.appspot.com/6405045/
>
> Affected files:
>   M src/org/plovr/Config.java
>
>
> Index: src/org/plovr/Config.java
> ===================================================================
> --- a/src/org/plovr/Config.java
> +++ b/src/org/plovr/Config.java
> @@ -619,6 +619,7 @@
>      // added to support generating externs without writing them to a file.
>      try {
>        File tempFile = File.createTempFile("source", "map");
> +      tempFile.deleteOnExit();
>        options.sourceMapOutputPath = tempFile.getAbsolutePath();
>      } catch (IOException e) {
>        logger.severe("A temp file for the Source Map could not be created");
>
>

[bolinfest, 2012-07-18 04:35:46]

http://codereview.appspot.com/6405045/diff/1/src/org/plovr/Config.java
File src/org/plovr/Config.java (right):

http://codereview.appspot.com/6405045/diff/1/src/org/plovr/Config.java#newcod...
src/org/plovr/Config.java:622: tempFile.deleteOnExit();
Nice fix! I wasn't aware of this API. Please go ahead and submit.

[bolinfest, 2012-07-18 04:36:29]

Also, did you verify that this works when you use ctrl+C to kill plovr?

[imirkin_alum.mit.edu, 2012-07-18 04:38:17]

No, but it should. If you kill -9, it won't. Like any finalizer, it's
not guaranteed to actually run. I'll double-check that it works with
^C and reinvestigate if it doesn't, but this definitely doesn't cover
every case.

On Wed, Jul 18, 2012 at 12:36 AM,  <bolinfest@gmail.com> wrote:
> Also, did you verify that this works when you use ctrl+C to kill plovr?
>
> http://codereview.appspot.com/6405045/

[bolinfest, 2012-07-18 04:41:33]

Right, it should be submitted either way since it's definitely an
improvement over what happens now -- I'm just curious when I should expect
it to work.

On Tue, Jul 17, 2012 at 9:38 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> No, but it should. If you kill -9, it won't. Like any finalizer, it's
> not guaranteed to actually run. I'll double-check that it works with
> ^C and reinvestigate if it doesn't, but this definitely doesn't cover
> every case.
>
> On Wed, Jul 18, 2012 at 12:36 AM,  <bolinfest@gmail.com> wrote:
> > Also, did you verify that this works when you use ctrl+C to kill plovr?
> >
> > http://codereview.appspot.com/6405045/
>

[imirkin_alum.mit.edu, 2012-07-18 04:41:41]

Yeah, just tried it with plovr in serve mode, the source*map file was
there, then I hit ^C, and it went away. Tested with

$ java -version
java version "1.6.0_33"
Java(TM) SE Runtime Environment (build 1.6.0_33-b03)
Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03, mixed mode)

On linux (3.0.6, FWIW, although I'd be thoroughly dissapointed if that
mattered).

On Wed, Jul 18, 2012 at 12:38 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> No, but it should. If you kill -9, it won't. Like any finalizer, it's
> not guaranteed to actually run. I'll double-check that it works with
> ^C and reinvestigate if it doesn't, but this definitely doesn't cover
> every case.
>
> On Wed, Jul 18, 2012 at 12:36 AM,  <bolinfest@gmail.com> wrote:
>> Also, did you verify that this works when you use ctrl+C to kill plovr?
>>
>> http://codereview.appspot.com/6405045/

[bolinfest, 2012-07-18 05:36:25]

Awesome -- thanks!

On Tue, Jul 17, 2012 at 9:41 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> Yeah, just tried it with plovr in serve mode, the source*map file was
> there, then I hit ^C, and it went away. Tested with
>
> $ java -version
> java version "1.6.0_33"
> Java(TM) SE Runtime Environment (build 1.6.0_33-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03, mixed mode)
>
> On linux (3.0.6, FWIW, although I'd be thoroughly dissapointed if that
> mattered).
>
> On Wed, Jul 18, 2012 at 12:38 AM, Ilia Mirkin <imirkin@alum.mit.edu>
> wrote:
> > No, but it should. If you kill -9, it won't. Like any finalizer, it's
> > not guaranteed to actually run. I'll double-check that it works with
> > ^C and reinvestigate if it doesn't, but this definitely doesn't cover
> > every case.
> >
> > On Wed, Jul 18, 2012 at 12:36 AM,  <bolinfest@gmail.com> wrote:
> >> Also, did you verify that this works when you use ctrl+C to kill plovr?
> >>
> >> http://codereview.appspot.com/6405045/
>