code review 63880043: gonewssh/ssh/terminal: Windows port

ssh/terminal: Windows port

[mattn, 2014-02-14 09:31:16]

Hello agl@golang.org, dave@cheney.net, hanwen@google.com, jpsugar@google.com,
golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/gosshnew

[hanwen-google, 2014-02-14 09:53:20]

thanks for looking into this!

* Can you also modify relevant other files so they become unix only?

* any reason for the odd naming? The go sources don't use underscores for
windows symbols.

[mattn, 2014-02-14 10:10:53]

> * Can you also modify relevant other files so they become unix only?

Yes, currently I don't have enough time to do it. But I'll do it.

> * any reason for the odd naming? The go sources don't use underscores for
> windows symbols.

Fixed.

[hanwen-google, 2014-02-14 11:01:27]

LGTM

If you can you fix up the non-windows files, I can submit this.

https://codereview.appspot.com/63880043/diff/40001/ssh/terminal/util_windows.go
File ssh/terminal/util_windows.go (right):

https://codereview.appspot.com/63880043/diff/40001/ssh/terminal/util_windows....
ssh/terminal/util_windows.go:55: small_rect struct {
these too.

[mattn, 2014-02-14 11:57:56]

https://codereview.appspot.com/63880043/diff/40001/ssh/terminal/util_windows.go
File ssh/terminal/util_windows.go (right):

https://codereview.appspot.com/63880043/diff/40001/ssh/terminal/util_windows....
ssh/terminal/util_windows.go:55: small_rect struct {
On 2014/02/14 11:01:27, hanwen-google wrote:
> these too.

Done.

[mattn, 2014-02-14 11:59:33]

> If you can you fix up the non-windows files, I can submit this.

Sorry, I don't understand clearly. What do you mean?

Do I need to update util.go, util_linuxgo, ...etc ? Then, I don't need to update
files in ssh/terminal/.

[hanwen-google, 2014-02-14 12:25:39]

I'm sorry - I had assumed the code was not split out by platform yet.

It seems to work, so I'm submitting it.



On Fri, Feb 14, 2014 at 12:59 PM,  <mattn.jp@gmail.com> wrote:
>> If you can you fix up the non-windows files, I can submit this.
>
>
> Sorry, I don't understand clearly. What do you mean?
>
> Do I need to update util.go, util_linuxgo, ...etc ? Then, I don't need
> to update files in ssh/terminal/.
>
> https://codereview.appspot.com/63880043/

-- 
Google Germany GmbH - ABC-Str. 19 - 20354 Hamburg
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg - Geschäftsführer: Graham Law,
Christine Elizabeth Flores

[hanwen-google, 2014-02-14 12:27:33]

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=c19406fdcdaa
***

gosshnew/ssh/terminal: Windows port

R=agl, dave, hanwen, jpsugar, golang-codereviews
CC=agl, dave, golang-codereviews, hanwen, jpsugar
https://codereview.appspot.com/63880043

Committer: Han-Wen Nienhuys <hanwen@google.com>

[hanwen-google, 2014-02-18 16:27:18]

On 2014/02/14 12:27:33, hanwen-google wrote:
> *** Submitted as
https://code.google.com/p/gosshnew/source/detail?r=c19406fdcdaa
> ***
> 
> gosshnew/ssh/terminal: Windows port
> 
> R=agl, dave, hanwen, jpsugar, golang-codereviews
> CC=agl, dave, golang-codereviews, hanwen, jpsugar
> https://codereview.appspot.com/63880043
> 
> Committer: Han-Wen Nienhuys <mailto:hanwen@google.com>

can you close the issue? Thanks!