Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 63720043: code review 63720043: cmd/gc: correct liveness for various non-returning functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rsc
Modified:
11 years, 4 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/gc: correct liveness for various non-returning functions When the liveness code doesn't know a function doesn't return (but the generated code understands that), the liveness analysis invents a control flow edge that is not really there, which can cause variables to seem spuriously live. This is particularly bad when the variables are uninitialized.

Patch Set 1 #

Patch Set 2 : diff -r 1924b7e9adf5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6c92cb840505 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M src/cmd/gc/popt.c View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/live.go View 1 2 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2014-02-14 05:38:19 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=b0a8d13410a6 *** cmd/gc: correct liveness for various non-returning functions When the liveness ...
11 years, 4 months ago (2014-02-14 05:38:24 UTC) #2
gobot
This CL appears to have broken the plan9-386-cnielsen builder.
11 years, 4 months ago (2014-02-14 07:18:21 UTC) #3
iant
11 years, 4 months ago (2014-02-14 15:36:15 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b