Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 63650044: code review 63650044: cmd/gc: handle variable initialization by block move in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
gobot, iant
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/gc: handle variable initialization by block move in liveness Any initialization of a variable by a block copy or block zeroing or by multiple assignments (componentwise copying or zeroing of a multiword variable) needs to emit a VARDEF. These cases were not. Fixes issue 7205.

Patch Set 1 #

Patch Set 2 : diff -r b2c3a8de38cc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M src/cmd/5g/cgen.c View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/cmd/8g/cgen.c View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/cmd/gc/pgen.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/plive.c View 1 5 chunks +9 lines, -10 lines 0 comments Download
M test/live.go View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-02-14 03:45:14 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=bc03ee8d688d *** cmd/gc: handle variable initialization by block move in liveness Any ...
11 years, 1 month ago (2014-02-14 03:45:20 UTC) #2
gobot
This CL appears to have broken the darwin-amd64-race-cheney builder.
11 years, 1 month ago (2014-02-14 09:29:47 UTC) #3
iant
11 years, 1 month ago (2014-02-14 15:47:56 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b