Issue 63640043: code review 63640043: cmd/gc: fix liveness for addressed results

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63640043: code review 63640043: cmd/gc: fix liveness for addressed results (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 4 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews

Visibility:
Public.

Description

cmd/gc: fix liveness for addressed results Was spuriously marking results live on entry to function.

Patch Set 2 : diff -r 188579e56bd8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b604a3f0cf7b https://code.google.com/p/go/ #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/cmd/gc/plive.c	View	1	1 chunk	+8 lines, -1 line	2 comments	Download
	M	test/live.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2014-02-14 02:11:45 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=46845f9bce29 *** cmd/gc: fix liveness for addressed results Was spuriously marking results ...

11 years, 4 months ago (2014-02-14 02:11:51 UTC) #2

gobot

This CL appears to have broken the linux-amd64-race builder.

11 years, 4 months ago (2014-02-14 03:32:08 UTC) #3

iant

LGTM but see comment. https://codereview.appspot.com/63640043/diff/40001/src/cmd/gc/plive.c File src/cmd/gc/plive.c (right): https://codereview.appspot.com/63640043/diff/40001/src/cmd/gc/plive.c#newcode671 src/cmd/gc/plive.c:671: bvset(uevar, i); This is C. ...

11 years, 4 months ago (2014-02-14 14:45:32 UTC) #4

rsc

11 years, 4 months ago (2014-02-14 15:59:40 UTC) #5

Message was sent while issue was closed.

https://codereview.appspot.com/63640043/diff/40001/src/cmd/gc/plive.c
File src/cmd/gc/plive.c (right):

https://codereview.appspot.com/63640043/diff/40001/src/cmd/gc/plive.c#newcode671
src/cmd/gc/plive.c:671: bvset(uevar, i);
On 2014/02/14 14:45:32, iant wrote:
> This is C.  You want a break statement here.  It doesn't look like it would
make
> any actual difference, but omitting the break is mystifying.

Yes, my mistake. Added in the next CL that touched this code.

Expand All Messages | Collapse All Messages