Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 63570048: New deployer version.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by frankban
Modified:
8 years, 7 months ago
Reviewers:
bac, mp+207452
Visibility:
Public.

Description

New deployer version. The new deployer fixes several bugs, including - unit errors during deployments; - only watching the units belonging to services included in the bundle being deployed; - fixed a failure in deploying a bundle when a unit is already in error in the environment; - gui bundle imports can use revision-less charm urls. Also updated the guiserver/deployer interaction to reflect changes in the deployer. Tests: `make unittest`. QA: - bootstrap a Juju env; - deploy the charm (`make deploy`); - wait for the charm to be ready; - start watching the guiserver logs: `juju ssh juju-gui/0 sudo tailf /var/log/upstart/guiserver.log`; - from the GUI, deploy the bundle in http://pastebin.ubuntu.com/6965041/ : it includes a bad-wolf failtester service that will fail with an install error; - even if bad-wolf units fail, the deployment proceeds: the relation between wordpress and mysql is eventually established and errors are printed to the guiserver logs; - wait for the first deployment to be completed; - from the GUI, deploy the bundle in http://pastebin.ubuntu.com/6965647/ : it just includes one haproxy service; - ensure the bundle deployment proceeds correctly even if the environments contains units in an error state; - done, thank you, destroy the juju environment. https://code.launchpad.net/~frankban/charms/precise/juju-gui/deployer-unit-errors/+merge/207452 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : New deployer version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D deps/juju-deployer-0.3.1.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/juju-deployer-0.3.2.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M server-requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/base.py View 4 chunks +4 lines, -4 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3
frankban
Please take a look.
8 years, 7 months ago (2014-02-20 14:45:33 UTC) #1
bac
LGTM and QA-ok. Thanks.
8 years, 7 months ago (2014-02-20 19:41:40 UTC) #2
frankban
8 years, 7 months ago (2014-02-21 10:26:56 UTC) #3
*** Submitted:

New deployer version.

The new deployer fixes several bugs, including
- unit errors during deployments;
- only watching the units belonging to services included
  in the bundle being deployed;
- fixed a failure in deploying a bundle when a unit is
  already in error in the environment;
- gui bundle imports can use revision-less charm urls.

Also updated the guiserver/deployer interaction to reflect
changes in the deployer.

Tests: `make unittest`.
QA:
- bootstrap a Juju env;
- deploy the charm (`make deploy`);
- wait for the charm to be ready;
- start watching the guiserver logs:
  `juju ssh juju-gui/0 sudo tailf /var/log/upstart/guiserver.log`;
- from the GUI, deploy the bundle in http://pastebin.ubuntu.com/6965041/ :
  it includes a bad-wolf failtester service that will 
  fail with an install error;
- even if bad-wolf units fail, the deployment proceeds: 
  the relation between wordpress and mysql is eventually established 
  and errors are printed to the guiserver logs;
- wait for the first deployment to be completed;
- from the GUI, deploy the bundle in http://pastebin.ubuntu.com/6965647/ :
  it just includes one haproxy service;
- ensure the bundle deployment proceeds correctly even if
  the environments contains units in an error state;
- done, thank you, destroy the juju environment.

R=bac
CC=
https://codereview.appspot.com/63570048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b