mstate: removing a node removes associated nodes.

mstate: removing a node removes associated nodes.



https://code.launchpad.net/~aramh/juju-core/mstate-lifecycle-relations/+merge/113292

Requires: https://code.launchpad.net/~aramh/juju-core/mstate-lifecycle/+merge/113276

(do not edit description out of merge proposal)

[aram, 2012-07-03 20:13:57]

Please take a look.

[niemeyer, 2012-07-03 21:16:16]

https://codereview.appspot.com/6356060/diff/2001/mstate/service.go
File mstate/service.go (right):

https://codereview.appspot.com/6356060/diff/2001/mstate/service.go#newcode133
mstate/service.go:133: change := bson.D{{"$set", bson.D{{"lifecycle",
life.Dying}, {"machineid", nil}}}}
This change looks a bit suspect in theory. It seems sane to keep the dying
resource assigned to the machine it was originally, because it won't magically
pop *out* of the machine before it is actually dead.  I suggest we have a team
call tomorrow to consider it, having in mind the lifecycle proposal, so that we
can establish a best-practice approach for similar situations.

https://codereview.appspot.com/6356060/diff/2001/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6356060/diff/2001/mstate/state.go#newcode136
mstate/state.go:136: change = bson.D{{"$set", bson.D{{"lifecycle", life.Dying},
{"machineid", nil}}}}
Ditto.

[aram, 2012-07-04 21:50:57]

Please take a look.

[niemeyer, 2012-07-06 18:55:20]

As we agreed over G+, let's please drop the machineid = nil part.

[aram, 2012-07-08 22:34:29]

On 2012/07/06 18:55:20, niemeyer wrote:
> As we agreed over G+, let's please drop the machineid = nil part.

Done.

[aram, 2012-07-08 22:34:49]

Please take a look.

[niemeyer, 2012-07-09 23:25:22]

LGTM

[aram, 2012-07-10 23:58:33]

*** Submitted:

mstate: removing a node removes associated nodes.

R=niemeyer
CC=
https://codereview.appspot.com/6356060