Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1290)

Issue 6355077: add environs.config package

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by fwereade
Modified:
11 years, 8 months ago
Reviewers:
gustavo, niemeyer, mp+113759
Visibility:
Public.

Description

add environs.config package The most important feature of this change is that the EnvironConfig type is no longer in the environs package, and so we will be able to use it from the state package without introducing a dependency on environs itself. https://code.launchpad.net/~fwereade/juju-core/separate-environs-config-package/+merge/113759 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -344 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/cmd_test.go View 5 chunks +8 lines, -7 lines 0 comments Download
D environs/config.go View 1 chunk +0 lines, -130 lines 0 comments Download
A environs/config/config.go View 1 chunk +168 lines, -0 lines 0 comments Download
M environs/config/config_test.go View 7 chunks +28 lines, -24 lines 0 comments Download
A environs/dummy/config.go View 1 chunk +46 lines, -0 lines 0 comments Download
M environs/dummy/environs.go View 6 chunks +24 lines, -58 lines 0 comments Download
M environs/dummy/environs_test.go View 2 chunks +6 lines, -6 lines 0 comments Download
M environs/ec2/config.go View 3 chunks +10 lines, -2 lines 0 comments Download
M environs/ec2/config_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M environs/ec2/ec2.go View 3 chunks +13 lines, -11 lines 0 comments Download
M environs/ec2/live_test.go View 3 chunks +5 lines, -4 lines 0 comments Download
M environs/ec2/local_test.go View 3 chunks +10 lines, -9 lines 0 comments Download
M environs/interface.go View 4 chunks +9 lines, -15 lines 0 comments Download
M environs/jujutest/test.go View 4 chunks +9 lines, -8 lines 0 comments Download
M environs/open.go View 1 chunk +43 lines, -39 lines 0 comments Download
M environs/open_test.go View 4 chunks +32 lines, -24 lines 0 comments Download
M environs/tools_test.go View 1 chunk +0 lines, -2 lines 0 comments Download
M juju/conn.go View 2 chunks +3 lines, -2 lines 0 comments Download
M service/provisioner/provisioner.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
fwereade
Please take a look.
11 years, 8 months ago (2012-07-06 15:58:47 UTC) #1
niemeyer
I had in mind something a lot simpler: https://gist.github.com/3061697
11 years, 8 months ago (2012-07-06 18:12:33 UTC) #2
fwereade
On 2012/07/06 18:12:33, niemeyer wrote: > I had in mind something a lot simpler: > ...
11 years, 8 months ago (2012-07-07 14:07:04 UTC) #3
gustavo_niemeyer.net
On Sat, Jul 7, 2012 at 11:07 AM, <fwereade@gmail.com> wrote: > I can see that ...
11 years, 8 months ago (2012-07-07 14:16:45 UTC) #4
gustavo_niemeyer.net
<niemeyer> fwereade: Actually, we don't need Get and Set.. <niemeyer> fwereade: If Validate wants to ...
11 years, 8 months ago (2012-07-07 14:26:48 UTC) #5
fwereade
11 years, 8 months ago (2012-07-07 16:16:35 UTC) #6
On 2012/07/07 14:26:48, gustavo_niemeyer.net wrote:
> <niemeyer> fwereade: Actually, we don't need Get and Set..
> <niemeyer> fwereade: If Validate wants to mutate the configuration,
> grab the map, do whatever, and return a new config
> <niemeyer> fwereade: This way a Config is immutable
> <niemeyer> fwereade: Which is a nice property and goes towards your desires
> <fwereade> niemeyer, ok, that would probably work for me
> <niemeyer> fwereade: So ValidateConfig(old, new *Config) => (valid
> *Config, err error)
> 
> 
> gustavo @ http://niemeyer.net

(and with Read/ReadBytes in environs, so we actually do get them validated as
they enter the system, rather than having to remember to do so later)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b