Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14546)

Issue 6355074: Reuses machine security groups for EC2 provider

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by jimbaker
Modified:
11 years, 9 months ago
Reviewers:
hazmat, mp+113654
Visibility:
Public.

Description

Reuses machine security groups for EC2 provider In trunk, this is the current behavior when terminating a machine: 1. Wait for the machine to transition to the terminated state, as reported by EC2; this can take considerable time. 2. At that time, attempt to delete the security group for that machine; security groups cannot be deleted unless all referring machines are in a terminated state. In practice, this strategy causes significant waiting for users and will often fail for larger environments. Instead, this branch changes the behavior such that it instead reuses any security groups from a previous instantiation of that environment, creating them only as necessary. The firewall portion of the provisioning agent will automatically adjust firewall rules for the corresponding machine security group as necessary, whether reused or not. https://code.launchpad.net/~jimbaker/juju/reuse-security-groups/+merge/113654 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reuses machine security groups for EC2 provider #

Patch Set 3 : Reuses machine security groups for EC2 provider #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -348 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/providers/ec2/__init__.py View 4 chunks +16 lines, -22 lines 0 comments Download
M juju/providers/ec2/launch.py View 2 chunks +6 lines, -24 lines 0 comments Download
M juju/providers/ec2/securitygroup.py View 2 chunks +0 lines, -43 lines 0 comments Download
M juju/providers/ec2/tests/common.py View 1 chunk +0 lines, -12 lines 0 comments Download
M juju/providers/ec2/tests/test_launch.py View 3 chunks +8 lines, -14 lines 0 comments Download
M juju/providers/ec2/tests/test_provider.py View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/providers/ec2/tests/test_securitygroup.py View 3 chunks +3 lines, -174 lines 0 comments Download
M juju/providers/ec2/tests/test_shutdown.py View 1 2 7 chunks +8 lines, -53 lines 0 comments Download
M juju/providers/ec2/tests/test_utils.py View 1 chunk +4 lines, -2 lines 0 comments Download
M juju/providers/ec2/utils.py View 2 chunks +4 lines, -2 lines 0 comments Download
M juju/state/tests/test_firewall.py View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jimbaker
Please take a look.
11 years, 9 months ago (2012-07-05 22:16:25 UTC) #1
hazmat
thanks for taking a look at this and cleaning up the various pep8 items. It ...
11 years, 9 months ago (2012-07-06 01:47:31 UTC) #2
jimbaker
Please take a look.
11 years, 9 months ago (2012-07-09 22:51:29 UTC) #3
jimbaker
Please take a look. https://codereview.appspot.com/6355074/diff/1/juju/providers/ec2/launch.py File juju/providers/ec2/launch.py (right): https://codereview.appspot.com/6355074/diff/1/juju/providers/ec2/launch.py#newcode102 juju/providers/ec2/launch.py:102: self._provider.environment_name, machine_id)) This emptying out ...
11 years, 9 months ago (2012-07-09 22:59:59 UTC) #4
jimbaker
11 years, 9 months ago (2012-07-09 23:00:50 UTC) #5
I added a test (in test_firewall) to address the removal of security group rules
for reused security groups.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b