Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 6354064: Reject \footnote ... \default without grob specification (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by dak
Modified:
6 years, 12 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Reject \footnote ... \default without grob specification The behavior of \footnote ... \default without grob specification is, for most purposes, indistinguishable from user error. In consequence, it has been turned into user error. As one consequence, support for the undocumented and inefficient compatibility mode for use of not-actually-time-based footnotes as an articulation (-\footnote ... \default) has been removed. This can occur as the result of convert-ly from older variants of \footnote syntax. Targetting a NO_SMART conversion error message of convert-ly for this use case is so much more tricky and error-prone than printing a warning at run-time that it has not been attempted.

Patch Set 1 #

Patch Set 2 : Error message was misleading for the -\footnote ... \default case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -32 lines) Patch
M lily/footnote-engraver.cc View 1 chunk +1 line, -22 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +13 lines, -10 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b