Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(663)

Issue 6354061: Refactor the PacketTagList class

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Peter Barnes
Modified:
9 years, 10 months ago
Reviewers:
Jeff Y, Mathieu Lacage
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Refactor the PacketTagList class: * Document the implementation. * Remove the freelist. Micro benchmarks show it's no faster than new/delete. * Trim copy-on-write to minimum copies; this was not completely implemented before. * Refactor copy-on-write to reduce code duplication * Add a Remove () method.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove _fp suffix from function pointer type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/network/model/packet-tag-list.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/network/model/packet-tag-list.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
Jeff Y
Hi Peter, I'm still looking through the code, but I had one quick question. This ...
9 years, 11 months ago (2012-07-26 17:20:29 UTC) #1
Peter Barnes
On 2012/07/26 17:20:29, Jeff Y wrote: > Hi Peter, > > I'm still looking through ...
9 years, 11 months ago (2012-07-26 18:20:29 UTC) #2
Mathieu Lacage
looks pretty good. I was wondering like jeff where the serialization of tags themselves was. ...
9 years, 11 months ago (2012-07-28 08:01:19 UTC) #3
Peter Barnes
On 2012/07/28 08:01:19, Mathieu Lacage wrote: > looks pretty good. I was wondering like jeff ...
9 years, 10 months ago (2012-08-20 17:57:40 UTC) #4
Jeff Y
Hi Peter, Your code looks good stylistically and functionally, although I'll admit I'm not super-familiar ...
9 years, 10 months ago (2012-08-20 21:08:42 UTC) #5
Peter Barnes
9 years, 10 months ago (2012-08-20 22:44:22 UTC) #6
Peter Barnes
9 years, 10 months ago (2012-08-20 22:50:16 UTC) #7
On 2012/08/20 21:08:42, Jeff Y wrote:
> 1) Would the ByteTagList benefit from using the COW semantics in a similar
> fashion, or is the benefit limited due to the simplicity of ByteTags? 

ByteTagList also uses COW semantics, but it's implemented differently.

> 2) Does COW affect traversing the PacketTagList in a deterministic fashion?

No.  Each packet sees an ordered list of PacketTags.  The ordering is a stack
(last in first out), and not modified by COW.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b