environs no longer imports state

environs no longer imports state

AIUI, the intent was always that environs should not require any knowledge
of the state package to function, so hopefully this is uncontroversial. The
necessary changes were just moving state.Info to environs.StateInfo (which
seems reasonable, because Environs are the sole source for StateInfos); and
moving state.AssignmentPolicy as well, which I'm a little less sure about
(but can, I think, be justified for the same reasons).

Now the dependency is broken, I can change State.EnvironConfig to return an
actual environs.EnvironConfig in a followup.

https://code.launchpad.net/~fwereade/juju-core/break-environs-state-dependency/+merge/113702

Requires: https://code.launchpad.net/~fwereade/juju-core/strict-parse-environ/+merge/113661

(do not edit description out of merge proposal)

[fwereade, 2012-07-06 08:09:34]

Please take a look.

[dave_cheney.net, 2012-07-06 08:18:21]

On 2012/07/06 08:09:34, fwereade wrote:
> Please take a look.

LGTM. Makes sense, but leads me to think that environs.StateInfo is not a
struct, just a few more configuration keys that describe a connection string to
get to Zookeeper. Given that the environ doesn't care about this, make StateInfo
should be a struct, but just an opaque blob/string, or even a *ConfigNode

[fwereade, 2012-07-06 09:43:46]

Please take a look.

[niemeyer, 2012-07-06 14:25:42]

Debated live.