Issue 6351049: Split Request into RequestExecutor.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351049: Split Request into RequestExecutor.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by askyles

Modified:
11 years, 10 months ago

Reviewers:
mlinder

CC:
google-api-dotnet-client-codereview_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 7

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+525 lines, -357 lines)			Patch
M	GoogleApis.Tools.CodeGen.IntegrationTests/Core/RequestTests.cs	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs	View	2 chunks	+41 lines, -0 lines	1 comment	Download
A	Src/GoogleApis.Tests/Apis/Requests/RequestExecutorTests.cs	View	1 chunk	+44 lines, -0 lines	1 comment	Download
M	Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs	View	7 chunks	+10 lines, -35 lines	2 comments	Download
M	Src/GoogleApis.Tests/GoogleApis.Tests.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Src/GoogleApis/Apis/Requests/MethodValidator.cs	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	Src/GoogleApis/Apis/Requests/Request.cs	View	9 chunks	+19 lines, -319 lines	0 comments	Download
A	Src/GoogleApis/Apis/Requests/RequestExecutor.cs	View	1 chunk	+399 lines, -0 lines	1 comment	Download
M	Src/GoogleApis/GoogleApis.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Src/GoogleApis/GoogleApis.Silverlight.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mlinder

11 years, 10 months ago (2012-06-28 22:04:33 UTC) #2

http://codereview.appspot.com/6351049/diff/1/GoogleApis.Tools.CodeGen.Integra...
File GoogleApis.Tools.CodeGen.IntegrationTests/Core/RequestTests.cs (right):

http://codereview.appspot.com/6351049/diff/1/GoogleApis.Tools.CodeGen.Integra...
GoogleApis.Tools.CodeGen.IntegrationTests/Core/RequestTests.cs:144: if
(!workerThread.WaitOne(500000))
That is a _long_ time. Change it to 30s or something.

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs
(right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs:46:
var req = (HttpWebRequest)HttpWebRequest.Create("http://www.example.com");
s/)H/) H/

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestExecutorTests.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestExecutorTests.cs:41: //   
Assert.AreEqual(0, webRequest.ContentLength);
Why is this commented?

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs (left):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs:569: webRequest =
(HttpWebRequest)request.CreateWebRequest((r) => { });
s/)r/) r/ everywhere

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs:147: }*/
I'd prefer it to not have commented-out methods in the code -- even in tests. Is
there any reason we can't run this test?

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Met...
File Src/GoogleApis/Apis/Requests/MethodValidator.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Met...
Src/GoogleApis/Apis/Requests/MethodValidator.cs:50: /// <returns>
Add a comment that this will return null when no parameters are loaded @
validator

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Req...
File Src/GoogleApis/Apis/Requests/RequestExecutor.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Req...
Src/GoogleApis/Apis/Requests/RequestExecutor.cs:46: /// <param
name="prepareRequest"></param>
Comment what this Func<> is for

Expand All Messages | Collapse All Messages