Split Request into RequestExecutor.

[mlinder, 2012-06-28 22:04:33]

http://codereview.appspot.com/6351049/diff/1/GoogleApis.Tools.CodeGen.Integra...
File GoogleApis.Tools.CodeGen.IntegrationTests/Core/RequestTests.cs (right):

http://codereview.appspot.com/6351049/diff/1/GoogleApis.Tools.CodeGen.Integra...
GoogleApis.Tools.CodeGen.IntegrationTests/Core/RequestTests.cs:144: if
(!workerThread.WaitOne(500000))
That is a _long_ time. Change it to 30s or something.

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs
(right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs:46:
var req = (HttpWebRequest)HttpWebRequest.Create("http://www.example.com");
s/)H/) H/

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestExecutorTests.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestExecutorTests.cs:41: //   
Assert.AreEqual(0, webRequest.ContentLength);
Why is this commented?

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs (left):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs:569: webRequest =
(HttpWebRequest)request.CreateWebRequest((r) => { });
s/)r/) r/ everywhere

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
File Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis.Tests/Apis/Reques...
Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs:147: }*/
I'd prefer it to not have commented-out methods in the code -- even in tests. Is
there any reason we can't run this test?

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Met...
File Src/GoogleApis/Apis/Requests/MethodValidator.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Met...
Src/GoogleApis/Apis/Requests/MethodValidator.cs:50: /// <returns>
Add a comment that this will return null when no parameters are loaded @
validator

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Req...
File Src/GoogleApis/Apis/Requests/RequestExecutor.cs (right):

http://codereview.appspot.com/6351049/diff/1/Src/GoogleApis/Apis/Requests/Req...
Src/GoogleApis/Apis/Requests/RequestExecutor.cs:46: /// <param
name="prepareRequest"></param>
Comment what this Func<> is for