Issue 6351047: watcher: renamed the fields Deleted to Removed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351047: watcher: renamed the fields Deleted to Removed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by TheMue

Modified:
11 years, 9 months ago

Reviewers:
mp+112386

Visibility:
Public.

Description

watcher: renamed the fields Deleted to Removed Several watcher return a struct containing two fields for added and removed subnodes or other informations inside a node content. The name of the field for removed informations has been inconsistent. Now all are changed into the identifier "Removed". https://code.launchpad.net/~themue/juju-core/go-watcher-rename-deleted-to-removed/+merge/112386 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : watcher: renamed the fields Deleted to Removed #

Patch Set 3 : watcher: renamed the fields Deleted to Removed #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -21 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/provisioning.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	state/watcher.go	View	1 2	4 chunks	+14 lines, -11 lines	0 comments	Download
M	state/watcher/watcher.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	state/watcher_test.go	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TheMue

11 years, 10 months ago (2012-06-29 09:33:13 UTC) #4

*** Submitted:

watcher: renamed the fields Deleted to Removed

Several watcher return a struct containing two fields
for added and removed subnodes or other informations
inside a node content. The name of the field for
removed informations has been inconsistent. Now all
are changed into the identifier "Removed".

R=niemeyer
CC=
https://codereview.appspot.com/6351047

Expand All Messages | Collapse All Messages