Issue 6350068: mstate: all nodes have a lifecycle

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6350068: mstate: all nodes have a lifecycle

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by aram

Modified:
11 years, 10 months ago

Reviewers:
niemeyer, mp+113276

Visibility:
Public.

Description

mstate: all nodes have a lifecycle As per Gustavo's proposal[1], all nodes have a lifecycle field used to avoid race conditions and guarantee a consistent state. [1] https://lists.ubuntu.com/archives/juju-dev/2012-July/000116.html https://code.launchpad.net/~aramh/juju-core/mstate-lifecycle/+merge/113276 Requires: https://code.launchpad.net/~aramh/juju-core/mstate-units-subordinate/+merge/113016 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: all nodes have a lifecycle #

Total comments: 2

Patch Set 3 : mstate: all nodes have a lifecycle #

Patch Set 4 : mstate: all nodes have a lifecycle #

Patch Set 5 : mstate: all nodes have a lifecycle #

Patch Set 6 : mstate: all nodes have a lifecycle #

Patch Set 7 : mstate: all nodes have a lifecycle #

Patch Set 8 : mstate: all nodes have a lifecycle #

Patch Set 9 : mstate: all nodes have a lifecycle #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -16 lines)			Patch
A	[revision details]	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mstate/machine.go	View	1 2 3 4 5 6 7	3 chunks	+8 lines, -2 lines	0 comments	Download
M	mstate/service.go	View	1 2 3 4 5 6 7	6 chunks	+10 lines, -3 lines	0 comments	Download
M	mstate/state.go	View	1 2	9 chunks	+31 lines, -8 lines	0 comments	Download
M	mstate/state_test.go	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	mstate/unit.go	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

That's great. LGTM, assuming the two changes below are pushed on all spots touched: https://codereview.appspot.com/6350068/diff/2001/mstate/life/lifecycle.go ...

11 years, 10 months ago (2012-07-03 20:29:24 UTC) #2

aram

11 years, 10 months ago (2012-07-10 23:50:44 UTC) #6

*** Submitted:

mstate: all nodes have a lifecycle

As per Gustavo's proposal[1], all nodes have a lifecycle field used to
avoid race conditions and guarantee a consistent state.

[1] https://lists.ubuntu.com/archives/juju-dev/2012-July/000116.html

R=niemeyer
CC=
https://codereview.appspot.com/6350068

Expand All Messages | Collapse All Messages