Issue 6348099: Added Encoder, Decoder types and test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6348099: Added Encoder, Decoder types and test.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by skelterjohn

Modified:
11 years, 10 months ago

Reviewers:
aram, mp+114659

Visibility:
Public.

Description

Added Encoder, Decoder types and test. https://code.launchpad.net/~jasmuth/mgo/skj-mgo-bson/+merge/114659 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	bson/bson.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bson/bson_test.go	View	2 chunks	+24 lines, -1 line	0 comments	Download
M	bson/decode.go	View	2 chunks	+41 lines, -0 lines	1 comment	Download
M	bson/encode.go	View	3 chunks	+22 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

aram

11 years, 10 months ago (2012-07-12 15:22:19 UTC) #2

https://codereview.appspot.com/6348099/diff/1/bson/decode.go
File bson/decode.go (right):

https://codereview.appspot.com/6348099/diff/1/bson/decode.go#newcode715
bson/decode.go:715: return
remove named return and replace the body with:

return &Decoder{r: r}

https://codereview.appspot.com/6348099/diff/1/bson/encode.go
File bson/encode.go (right):

https://codereview.appspot.com/6348099/diff/1/bson/encode.go#newcode432
bson/encode.go:432: return
Ditto as for NewDecoder.

Expand All Messages | Collapse All Messages