Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 63480043: Replace kEmptyString wth OnceInit initialized string*

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by scottmg
Modified:
10 years, 2 months ago
Reviewers:
xiaofeng
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Replace kEmptyString wth OnceInit initialized string* This removes the global constructor call for std::string kEmptyString. This is an application with minor changes of b/7549760 from the internal version protobuf.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -351 lines) Patch
M src/google/protobuf/compiler/cpp/cpp_string_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/google/protobuf/compiler/plugin.pb.h View 15 chunks +45 lines, -45 lines 0 comments Download
M src/google/protobuf/compiler/plugin.pb.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M src/google/protobuf/descriptor.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M src/google/protobuf/descriptor.pb.h View 69 chunks +207 lines, -207 lines 0 comments Download
M src/google/protobuf/descriptor.pb.cc View 39 chunks +69 lines, -69 lines 0 comments Download
M src/google/protobuf/generated_message_reflection.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/google/protobuf/generated_message_util.h View 2 chunks +12 lines, -2 lines 0 comments Download
M src/google/protobuf/generated_message_util.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/google/protobuf/repeated_field.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
scottmg
10 years, 2 months ago (2014-02-13 21:38:45 UTC) #1
scottmg
I'm not sure if you want this applied, but we would like to get rid ...
10 years, 2 months ago (2014-02-13 21:43:59 UTC) #2
xiaofeng
LGTM Committed to svn as r517
10 years, 2 months ago (2014-02-13 22:10:39 UTC) #3
scottmg
10 years, 2 months ago (2014-02-13 22:35:30 UTC) #4
Thanks!


On Thu, Feb 13, 2014 at 2:10 PM, <xiaofeng@google.com> wrote:

> LGTM
>
> Committed to svn as r517
>
> https://codereview.appspot.com/63480043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b