Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 6347062: Doc: document \on-the-fly (2579) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Trevor Daniels
Modified:
7 years ago
Reviewers:
thomasmorley65, dak, Graham Percival, eluzew, lilypond-devel, t.daniels
CC:
lilypond-user_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: document \on-the-fly (2579) - explain syntax - list provided procedures (Thanks to Eluze for the suggestion)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added on-page #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M Documentation/notation/input.itely View 1 2 chunks +57 lines, -0 lines 2 comments Download

Messages

Total messages: 12
Trevor Daniels
A patch is up for review for issue 2579 to document the use of \on-the-fly. ...
7 years ago (2012-07-03 22:40:45 UTC) #1
Graham Percival
LGTM http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely#newcode1008 Documentation/notation/input.itely:1008: @quotation IIRC @multitable is already indented, so I ...
7 years ago (2012-07-04 16:22:49 UTC) #2
t.daniels_treda.co.uk
<graham@percival-music.ca> wrote Wednesday, July 04, 2012 5:22 PM > http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely#newcode1008 > Documentation/notation/input.itely:1008: @quotation > IIRC ...
7 years ago (2012-07-04 20:08:27 UTC) #3
Graham Percival
On Wed, Jul 04, 2012 at 09:08:14PM +0100, Trevor Daniels wrote: > > @multitable is ...
7 years ago (2012-07-04 20:23:23 UTC) #4
Trevor Daniels
Omitted to add -devel to Reviewers when I uploaded this patch. Trevor
7 years ago (2012-07-04 20:35:05 UTC) #5
thomasmorley65
http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely#newcode1018 Documentation/notation/input.itely:1018: @item not-first-page @tab not first page in the book? ...
7 years ago (2012-07-05 12:48:32 UTC) #6
Trevor Daniels
On 2012/07/05 12:48:32, thomasmorley65 wrote: > Please add the newly implemented on-page-feature. Done. I changed ...
7 years ago (2012-07-06 07:20:20 UTC) #7
Trevor Daniels
http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.itely#newcode1017 Documentation/notation/input.itely:1017: @item (on-page nmbr) @tab is page number = nmbr? ...
7 years ago (2012-07-06 07:31:08 UTC) #8
dak
http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.itely#newcode1017 Documentation/notation/input.itely:1017: @item (on-page nmbr) @tab is page number = nmbr? ...
7 years ago (2012-07-06 07:38:05 UTC) #9
Trevor Daniels
On 2012/07/06 07:38:05, dak wrote: Yes, it's best to drop the verb. That is more ...
7 years ago (2012-07-06 08:29:08 UTC) #10
Graham Percival
LGTM
7 years ago (2012-07-09 04:48:15 UTC) #11
Trevor Daniels
7 years ago (2012-07-11 06:55:07 UTC) #12
Patch pushed
91ca3dbe2cd40f8eedce48ee02c7c98a2ec89413
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b