Issue 6347059: aws: add Region.Name and Regions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6347059: aws: add Region.Name and Regions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by dave

Modified:
11 years, 10 months ago

Reviewers:
mp+113133

Visibility:
Public.

Description

aws: add Region.Name and Regions This proposal adds a canonical Name field to the region struct. This field is needed for specifying the LocationConstraint when using PutBucket (to come in a followup branch). I also took the opportunity to move the Regions map into aws.go https://code.launchpad.net/~dave-cheney/goamz/aws-region-name/+merge/113133 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : aws: add Region.Name and Regions #

Patch Set 3 : aws: add Region.Name and Regions #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	aws/aws.go	View	1	7 chunks	+14 lines, -0 lines	0 comments	Download
M	aws/aws_test.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

11 years, 10 months ago (2012-07-02 23:43:09 UTC) #4

*** Submitted:

aws: add Region.Name and Regions

This proposal adds a canonical Name field to the region struct. 
This field is needed for specifying the LocationConstraint when
using PutBucket (to come in a followup branch). I also took the 
opportunity to move the Regions map into aws.go

R=niemeyer
CC=
https://codereview.appspot.com/6347059

Expand All Messages | Collapse All Messages