Issue 6345086: Doc: Update changing context default settings (2322) (Closed)
|
Created:
11 years, 9 months ago by Trevor Daniels Modified:
11 years, 9 months ago CC:
lilypond-devel_gnu.org Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/ Visibility:
Public. |
DescriptionDoc: Update changing context default settings (2322)
- rewrite complete section to include description of
\with and add possibility of including predefined
commands in \context blocks in \layout
- uses shorter, more specific examples
Patch Set 1 #
Total comments: 2
Patch Set 2 : Changes in response to David's comments, plus mention of leaving out \context. #
Total comments: 3
Patch Set 3 : More accurate description of music in \layout #MessagesTotal messages: 13
This is a substantial change. I took the opportunity to deal with a TODO in the file - document \with - as this made for a more sensible organisation of the section. I'd like reviewers to consider in particular - factual accuracy (I was not confident about some parts) - quality of the examples (are short separate ones better?) - and of course general clarity Trevor
Sign in to reply to this message.
http://codereview.appspot.com/6345086/diff/1/Documentation/notation/changing-... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6345086/diff/1/Documentation/notation/changing-... Documentation/notation/changing-defaults.itely:698: property takes effect from the moment the command is encountered These commands create music events, making the changes take effect at the point of time the music is being processed. http://codereview.appspot.com/6345086/diff/1/Documentation/notation/changing-... Documentation/notation/changing-defaults.itely:702: values of context and grob properties provided by LilyPond itself. values of context and grob properties at the creation of the context.
Sign in to reply to this message.
Correct typo http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:843: fontSize = #-4 Whoops, should be \set fontsize = #-4
Sign in to reply to this message.
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:844: \override Stem #'thickness = #4.0 That overrides Stem thickness in all Bottom contexts. It seems unlikely that a single setting will be nice for MensuralVoice, TabVoice and Voice alike.
Sign in to reply to this message.
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:844: \override Stem #'thickness = #4.0 On 2012/07/11 21:47:58, dak wrote: > That overrides Stem thickness in all Bottom contexts. > It seems unlikely that a single setting will be nice > for MensuralVoice, TabVoice and Voice alike. True, but that's not an issue here. An example that shows the effect of the code clearly is all that is required.
Sign in to reply to this message.
On 2012/07/12 09:31:40, Trevor Daniels wrote: > http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... > File Documentation/notation/changing-defaults.itely (right): > > http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... > Documentation/notation/changing-defaults.itely:844: \override Stem #'thickness = > #4.0 > On 2012/07/11 21:47:58, dak wrote: > > > That overrides Stem thickness in all Bottom contexts. > > It seems unlikely that a single setting will be nice > > for MensuralVoice, TabVoice and Voice alike. > > True, but that's not an issue here. An example that > shows the effect of the code clearly is all that is > required. It would do that also if you wrote \override Voice.Stem ...
Sign in to reply to this message.
<dak@gnu.org> wrote Thursday, July 12, 2012 10:35 AM > On 2012/07/12 09:31:40, Trevor Daniels wrote: > http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... >> Documentation/notation/changing-defaults.itely:844: \override Stem > #'thickness = #4.0 >> On 2012/07/11 21:47:58, dak wrote: > >> > That overrides Stem thickness in all Bottom contexts. >> > It seems unlikely that a single setting will be nice >> > for MensuralVoice, TabVoice and Voice alike. > >> True, but that's not an issue here. An example that >> shows the effect of the code clearly is all that is >> required. > > It would do that also if you wrote > \override Voice.Stem ... Hmm. Suppose we change the introductory paragraph to this example to say, "in which case the Score context is assumed unless explicitly stated", and use Voice.Stem in the \override example. How does that sound? Trevor > http://codereview.appspot.com/6345086/
Sign in to reply to this message.
On 2012/07/12 09:52:35, t.daniels_treda.co.uk wrote: > <mailto:dak@gnu.org> wrote Thursday, July 12, 2012 10:35 AM > > > > On 2012/07/12 09:31:40, Trevor Daniels wrote: > > > http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changi... > >> Documentation/notation/changing-defaults.itely:844: \override Stem > > #'thickness = #4.0 > >> On 2012/07/11 21:47:58, dak wrote: > > > >> > That overrides Stem thickness in all Bottom contexts. > >> > It seems unlikely that a single setting will be nice > >> > for MensuralVoice, TabVoice and Voice alike. > > > >> True, but that's not an issue here. An example that > >> shows the effect of the code clearly is all that is > >> required. > > > > It would do that also if you wrote > > \override Voice.Stem ... > > Hmm. Suppose we change the introductory paragraph > to this example to say, "in which case the Score context is > assumed unless explicitly stated", and use Voice.Stem in > the \override example. > > How does that sound? Uhm, wrong? \override in an output definition (as opposed to a context definition) is just interpreted as ordinary property-setting music. If you don't specify a context type explicitly here, it does not apply to the Score context, but rather to all Bottom contexts (which Score is not). In contrast, an \override command in a context definition is _not_ interpreted as a music command and can't take a context name with a period before the property. You also can't use the music command "\set" in a context definition, but have to use an assignment. Basically, the effect of context-setting music in an output definition (like \layout) is like writing the respective set/override at the start of _every_ context.
Sign in to reply to this message.
On 2012/07/12 10:20:01, dak wrote: > Uhm, wrong? [etc] Thanks David - that's the explanation I needed :) I'll make amendments and post a new patch-set. Trevor
Sign in to reply to this message.
On 2012/07/12 10:44:04, Trevor Daniels wrote: > On 2012/07/12 10:20:01, dak wrote: > > > Uhm, wrong? > [etc] > > Thanks David - that's the explanation I needed :) I am not happy with all those fine distinctions and almost, but not quite, similar syntax for property manipulations in different contexts (no pun intended). And I am not sure we really want to explain the whole ugly story. But at least those parts we tell, we should get right. And I am not really happy that this is not easy. > I'll make amendments and post a new patch-set. Thanks.
Sign in to reply to this message.
On 2012/07/12 10:53:19, dak wrote: > I am not happy with all those fine distinctions and almost, > but not quite, similar syntax for property manipulations > in different contexts I've done a lot of LP documentation in the past, and find it is frequently the case that attempts to write down precise details exposes nasties like this. But while they exist it is only fair to users to try to explain at least part of the story. I try to get things right by experimentation, but that works only up to a point; a clear explanation from someone who understands the internal working is a great help. Trevor
Sign in to reply to this message.
LGTM
Sign in to reply to this message.
|
