Issue 6345084: all: rename service => worker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6345084: all: rename service => worker (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by dave

Modified:
12 years, 8 months ago

Reviewers:
mp+114333

Visibility:
Public.

Description

all: rename service => worker As discussed in the 03/07/2012 team meeting, among a poor field of candidates, worker(s) was the prefered name for the code that runs inside an agent. eg, the Provisioner worker runs inside the Provisioning agent. note: also fixed a gofmt issue in state/ which had been bugging me. https://code.launchpad.net/~dave-cheney/juju-core/go-service-rename/+merge/114333 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: rename service => worker #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/provisioning.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	store/mgo_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	store/store.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	store/store_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/machiner/machiner_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

12 years, 8 months ago (2012-07-11 23:37:24 UTC) #3

*** Submitted:

all: rename service => worker

As discussed in the 03/07/2012 team meeting, among a poor field of
candidates, worker(s) was the prefered name for the code that runs
inside an agent. eg, the Provisioner worker runs inside the 
Provisioning agent.

note: also fixed a gofmt issue in state/ which had been bugging me.

R=niemeyer
CC=
https://codereview.appspot.com/6345084

Expand All Messages | Collapse All Messages