environ configs are now parsed strictly

environ configs are now parsed strictly

That is to say, a new Schema.StrictFieldMap type -- which errors on
unrecognised keys -- was added, and is now used by the dummy and ec2
environs for config loading.

https://code.launchpad.net/~fwereade/juju-core/strict-parse-environ/+merge/113661

(do not edit description out of merge proposal)

[fwereade, 2012-07-05 23:21:37]

Please take a look.

[dave_cheney.net, 2012-07-06 05:14:35]

On 2012/07/05 23:21:37, fwereade wrote:
> Please take a look.

LGTM. Thanks.

[niemeyer, 2012-07-06 10:38:23]

LGTM! Thanks!

https://codereview.appspot.com/6345071/diff/1/environs/ec2/config.go
File environs/ec2/config.go (right):

https://codereview.appspot.com/6345071/diff/1/environs/ec2/config.go#newcode33
environs/ec2/config.go:33: "type":                 schema.Const("ec2"),
Hah.

https://codereview.appspot.com/6345071/diff/1/schema/schema.go
File schema/schema.go (right):

https://codereview.appspot.com/6345071/diff/1/schema/schema.go#newcode286
schema/schema.go:286: // StrictFieldMap acts as FieldMap, but returns an error
if encounters
// StrictFieldMap returns a Checker that acts as the one returned by FieldMap,
// but the Checker returns an error if it encounters an unknown key.

[fwereade, 2012-07-06 12:30:15]

*** Submitted:

environ configs are now parsed strictly

That is to say, a new Schema.StrictFieldMap type -- which errors on
unrecognised keys -- was added, and is now used by the dummy and ec2
environs for config loading.

R=dfc, niemeyer
CC=
https://codereview.appspot.com/6345071