Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 6344071: service/provisioner: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by dave
Modified:
11 years, 10 months ago
Reviewers:
mp+113141
Visibility:
Public.

Description

service/provisioner: new package This proposal moves the Provisioner to a new package so it can be imported by commands (jujud etc) and other packages (environs/jujutest). note: * MachinerAgent/Machiner will be handled in a following branch. * suite_test.go is duplicated for the moment, once Williams test refactor is completed, this duplication will be removed. https://code.launchpad.net/~dave-cheney/juju-core/master/+merge/113141 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : service/provisioner: new package #

Patch Set 3 : service/provisioner: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -21 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/provisioning.go View 2 chunks +2 lines, -1 line 0 comments Download
A service/provisioner/export_test.go View 1 chunk +15 lines, -0 lines 0 comments Download
M service/provisioner/provisioner.go View 1 chunk +1 line, -1 line 0 comments Download
M service/provisioner/provisioner_test.go View 17 chunks +20 lines, -19 lines 0 comments Download
A service/provisioner/suite_test.go View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dave_cheney.net
Please take a look.
11 years, 10 months ago (2012-07-03 02:52:32 UTC) #1
niemeyer
Nice, LGTM!
11 years, 10 months ago (2012-07-03 04:20:37 UTC) #2
dave_cheney.net
11 years, 10 months ago (2012-07-03 05:19:11 UTC) #3
*** Submitted:

service/provisioner: new package

This proposal moves the Provisioner to a new package so it can 
be imported by commands (jujud etc) and other packages 
(environs/jujutest).

note: 

* MachinerAgent/Machiner will be handled in a following branch.

* suite_test.go is duplicated for the moment, once Williams test
refactor is completed, this duplication will be removed.

R=niemeyer
CC=
https://codereview.appspot.com/6344071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b