Issue 6344047: Refactor ETag logic into a Decorator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6344047: Refactor ETag logic into a Decorator.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by askyles

Modified:
11 years, 10 months ago

Reviewers:
mlinder

CC:
google-api-dotnet-client-codereview_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Minor updates. #

Total comments: 4

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -69 lines)			Patch
A	Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs	View	1 chunk	+28 lines, -0 lines	1 comment	Download
M	Src/GoogleApis.Tests/Apis/Requests/RequestTest.cs	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	Src/GoogleApis.Tests/GoogleApis.Tests.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Src/GoogleApis/Apis/Requests/Request.cs	View	4 chunks	+14 lines, -55 lines	0 comments	Download
A	Src/GoogleApis/Apis/Requests/RequestDecorators/EtagRequestDecorator.cs	View	1 chunk	+92 lines, -0 lines	3 comments	Download
M	Src/GoogleApis/GoogleApis.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Src/GoogleApis/GoogleApis.Silverlight.csproj	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mlinder

11 years, 10 months ago (2012-06-27 20:21:47 UTC) #3

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis.Tests/Apis/Req...
File
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs
(right):

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis.Tests/Apis/Req...
Src/GoogleApis.Tests/Apis/Requests/RequestDecorators/EtagRequestDecoratorTests.cs:12:
public class EtagRequestDecoratorTests
EtagRequest* or ETagRequest*? I'd go with the second one in order to remain
consistent.

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis/Apis/Requests/...
File Src/GoogleApis/Apis/Requests/RequestDecorators/EtagRequestDecorator.cs
(right):

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis/Apis/Requests/...
Src/GoogleApis/Apis/Requests/RequestDecorators/EtagRequestDecorator.cs:12: ///
Decorate a request with ETag information. Sets the IfMatch/IfNoneMatch
Finish this comment

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis/Apis/Requests/...
Src/GoogleApis/Apis/Requests/RequestDecorators/EtagRequestDecorator.cs:30:
public string ETag { get; set; }
Either make these read-only/private set, or remove them from the constructor and
use the { foo = bar } pattern

http://codereview.appspot.com/6344047/diff/3001/Src/GoogleApis/Apis/Requests/...
Src/GoogleApis/Apis/Requests/RequestDecorators/EtagRequestDecorator.cs:65: 
remove empty line

Expand All Messages | Collapse All Messages