Issue 6343080: s3: fix regions that require lowercase buckets.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6343080: s3: fix regions that require lowercase buckets. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by dave

Modified:
11 years, 10 months ago

Reviewers:
mp+113664

Visibility:
Public.

Description

s3: fix regions that require lowercase buckets. US regions are lax on this restriction, but other later regions enforce bucket names that are also valid dns names. https://code.launchpad.net/~dave-cheney/goamz/s3-lower-case-bucket-names/+merge/113664 Requires: https://code.launchpad.net/~dave-cheney/goamz/s3-location-constraint/+merge/112478 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : s3: always lowercase bucket names #

Patch Set 3 : s3: fix regions that require lowercase buckets. #

Patch Set 4 : s3: fix regions that require lowercase buckets. #

Patch Set 5 : s3: fix regions that require lowercase buckets. #

Total comments: 2

Patch Set 6 : s3: fix regions that require lowercase buckets. #

Patch Set 7 : s3: fix regions that require lowercase buckets. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	aws/aws.go	View	1 2 3 4 5	6 chunks	+8 lines, -2 lines	0 comments	Download
M	s3/s3.go	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	s3/s3i_test.go	View	1 2 3 4 5	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

niemeyer

LGTM if the us-west situation is sorted out. https://codereview.appspot.com/6343080/diff/7001/aws/aws.go File aws/aws.go (right): https://codereview.appspot.com/6343080/diff/7001/aws/aws.go#newcode50 aws/aws.go:50: false, ...

11 years, 10 months ago (2012-07-11 22:44:43 UTC) #5

dave_cheney.net

Please take a look. https://codereview.appspot.com/6343080/diff/7001/aws/aws.go File aws/aws.go (right): https://codereview.appspot.com/6343080/diff/7001/aws/aws.go#newcode50 aws/aws.go:50: false, On 2012/07/11 22:44:43, niemeyer ...

11 years, 10 months ago (2012-07-12 01:57:34 UTC) #6

dave_cheney.net

11 years, 10 months ago (2012-07-12 02:03:35 UTC) #7

*** Submitted:

s3: fix regions that require lowercase buckets.

US regions are lax on this restriction, but other later regions
enforce bucket names that are also valid dns names.

R=niemeyer
CC=
https://codereview.appspot.com/6343080

Expand All Messages | Collapse All Messages