mstate: keep charms in mgo.

mstate: keep charms in mgo.



https://code.launchpad.net/~aramh/juju-core/mstate-charm-basic/+merge/111928

(do not edit description out of merge proposal)

[aram, 2012-06-25 20:00:56]

Please take a look.

[aram, 2012-06-25 22:55:27]

Please take a look.

[niemeyer, 2012-06-26 04:31:08]

Nice, LGTM.

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go
File mstate/charm.go (right):

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go#newcode10
mstate/charm.go:10: Url          *charm.URL `bson:"_id"`
s/Url/URL/

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go#newcode30
mstate/charm.go:30: return nil, err
return nil, fmt.Errorf("can't parse charm bundle URL: %q", cdoc.BundleURL)

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go#newcode86
mstate/state.go:86: // Charm returns a charm by the given id.
// Charm returns the charm with given URL.

Please fix in the state package too.

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go#newcode87
mstate/state.go:87: func (s *State) Charm(curl *charm.URL) (stch *Charm, err
error) {
I know it's coming from the state package, but these return names seem to
obfuscate the result rather than helping out. I suggest using (*Charm, error).

[aram, 2012-06-26 15:37:50]

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go
File mstate/charm.go (right):

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go#newcode10
mstate/charm.go:10: Url          *charm.URL `bson:"_id"`
On 2012/06/26 04:31:08, niemeyer wrote:
> s/Url/URL/

Done.

https://codereview.appspot.com/6341050/diff/2003/mstate/charm.go#newcode30
mstate/charm.go:30: return nil, err
On 2012/06/26 04:31:08, niemeyer wrote:
> return nil, fmt.Errorf("can't parse charm bundle URL: %q", cdoc.BundleURL)

Done.

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go#newcode86
mstate/state.go:86: // Charm returns a charm by the given id.
On 2012/06/26 04:31:08, niemeyer wrote:
> // Charm returns the charm with given URL.
> 
> Please fix in the state package too.

Done.

https://codereview.appspot.com/6341050/diff/2003/mstate/state.go#newcode87
mstate/state.go:87: func (s *State) Charm(curl *charm.URL) (stch *Charm, err
error) {
On 2012/06/26 04:31:08, niemeyer wrote:
> I know it's coming from the state package, but these return names seem to
> obfuscate the result rather than helping out. I suggest using (*Charm, error).

Done.

[aram, 2012-06-26 15:38:50]

*** Submitted:

mstate: keep charms in mgo.

R=niemeyer
CC=
https://codereview.appspot.com/6341050