Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(592)

Issue 6332052: Make gtest work with libc++.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Jeffrey Yasskin
Modified:
4 years, 10 months ago
Reviewers:
michael181189
CC:
googletestframework_googlegroups.com
Visibility:
Public.

Description

In C++11 mode, #include <tuple> unconditionally, and 'using' std::tuple and friends into std::tr1. In C++98 mode, libc++ doesn't define tuple<>, so force GTEST_USE_OWN_TR1_TUPLE.

Patch Set 1 #

Patch Set 2 : Set GTEST_USE_OWN_TR1_TUPLE for libc++ in C++98 mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M include/gtest/internal/gtest-port.h View 1 3 chunks +29 lines, -8 lines 0 comments Download

Messages

Total messages: 2
Jeffrey Yasskin
5 years, 5 months ago (2012-06-24 02:22:57 UTC) #1
michael181189
4 years, 10 months ago (2013-02-02 22:09:08 UTC) #2
Thanks. Did the trick with apple clang and std=c++11 -stdlib=libc++ which was
broken because gtest looked for tr1/tuple instead of tuple

Michael
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d