Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 6332048: state: adding of FlagWatcher and integration into Service (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by TheMue
Modified:
11 years, 9 months ago
Reviewers:
mp+111671
Visibility:
Public.

Description

state: adding of FlagWatcher and integration into Service The port of Firewall (in a different CL) needs the implementation of the FlagWatcher and its integration into Service to watch the exposed flag. Both is done in this CL. https://code.launchpad.net/~themue/juju-core/go-state-added-exposed-watcher/+merge/111671 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : state: Adding of ExposedWatcher and integration into Service. #

Total comments: 4

Patch Set 3 : state: Adding of ExposedWatcher and integration into Service. #

Patch Set 4 : state: adding of FlagWatcher and integration into Service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M state/service.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M state/watcher.go View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M state/watcher_test.go View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7
TheMue
Please take a look.
11 years, 9 months ago (2012-06-22 20:04:38 UTC) #1
niemeyer
Looks fine, but please see the note below. https://codereview.appspot.com/6332048/diff/1/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6332048/diff/1/state/watcher.go#newcode169 state/watcher.go:169: if ...
11 years, 9 months ago (2012-06-22 20:11:50 UTC) #2
TheMue
Please take a look.
11 years, 9 months ago (2012-06-22 20:20:30 UTC) #3
niemeyer
https://codereview.appspot.com/6332048/diff/4001/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6332048/diff/4001/state/watcher.go#newcode116 state/watcher.go:116: // by the existence of a node. // FlagWatcher ...
11 years, 9 months ago (2012-06-22 20:26:43 UTC) #4
TheMue
Please take a look. https://codereview.appspot.com/6332048/diff/4001/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6332048/diff/4001/state/watcher.go#newcode116 state/watcher.go:116: // by the existence of ...
11 years, 9 months ago (2012-06-22 20:33:06 UTC) #5
niemeyer
<niemeyer> TheMue: LGTM.. please just fix the CL description when submitting <niemeyer> TheMue: Btw, the ...
11 years, 9 months ago (2012-06-22 20:36:25 UTC) #6
TheMue
11 years, 9 months ago (2012-06-22 20:45:38 UTC) #7
*** Submitted:

state: adding of FlagWatcher and integration into Service

The port of Firewall (in a different CL) needs the implementation
of the FlagWatcher and its integration into Service to watch the
exposed flag. Both is done in this CL.

R=niemeyer
CC=
https://codereview.appspot.com/6332048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b