Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4874)

Issue 6331066: disable fsync on zk to speed tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by hazmat
Modified:
11 years, 10 months ago
Reviewers:
mp+112188
Visibility:
Public.

Description

disable fsync on zk to speed tests. [r=bcsaller,clint-fewbar] The tests exercise zk heavily, and by defaults its configured for per operation fsync to disk, disabling the fsync greatly speeds up full test runs. https://code.launchpad.net/~hazmat/juju/test-sans-fsync/+merge/112188 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : disable fsync on zk to speed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/lib/zk.py View 3 chunks +6 lines, -3 lines 0 comments Download
M juju/tests/common.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
hazmat
Please take a look.
11 years, 10 months ago (2012-06-26 18:45:36 UTC) #1
hazmat
11 years, 10 months ago (2012-06-27 16:02:54 UTC) #2
*** Submitted:

disable fsync on zk to speed tests.

[r=bcsaller,clint-fewbar]

The tests exercise zk heavily, and by defaults its configured
for per operation fsync to disk, disabling the fsync greatly
speeds up full test runs.

R=
CC=
https://codereview.appspot.com/6331066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b