Issue 63310043: code review 63310043: runtime: fix windows cpu profiler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63310043: code review 63310043: runtime: fix windows cpu profiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dvyukov

Modified:
11 years, 4 months ago

Reviewers:
brainman, rsc

CC:
rsc, brainman, golang-codereviews

Visibility:
Public.

Description

runtime: fix windows cpu profiler Currently it periodically fails with the following message. The immediate cause is the wrong base register when obtaining g in sys_windows_amd64/386.s. But there are several secondary problems as well. runtime: unknown pc 0x0 after stack split panic: invalid memory address or nil pointer dereference fatal error: panic during malloc [signal 0xc0000005 code=0x0 addr=0x60 pc=0x42267a] runtime stack: runtime.panic(0x7914c0, 0xc862af) c:/src/perfer/work/windows-amd64-a15f344a9efa/go/src/pkg/runtime/panic.c:217 +0x2c runtime: unexpected return pc for runtime.externalthreadhandler called from 0x0

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
M	src/pkg/runtime/os_windows.c	View	1 2	3 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/runtime/sys_windows_386.s	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_windows_amd64.s	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 4 months ago (2014-02-13 16:57:44 UTC) #1

dvyukov

11 years, 4 months ago (2014-02-14 05:20:59 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6c92cb840505 ***

runtime: fix windows cpu profiler
Currently it periodically fails with the following message.
The immediate cause is the wrong base register when obtaining g
in sys_windows_amd64/386.s.
But there are several secondary problems as well.

runtime: unknown pc 0x0 after stack split
panic: invalid memory address or nil pointer dereference
fatal error: panic during malloc
[signal 0xc0000005 code=0x0 addr=0x60 pc=0x42267a]

runtime stack:
runtime.panic(0x7914c0, 0xc862af)
       
c:/src/perfer/work/windows-amd64-a15f344a9efa/go/src/pkg/runtime/panic.c:217
+0x2c
runtime: unexpected return pc for runtime.externalthreadhandler called from 0x0

R=rsc, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/63310043

Expand All Messages | Collapse All Messages