Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1300)

Issue 6330053: Add Version field to ContentChange

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by fwereade
Modified:
11 years, 10 months ago
Reviewers:
mp+111811
Visibility:
Public.

Description

Add Version field to ContentChange As discussed on IRC. One notable consequence is that the ContentWatcher now fires on version changes that don't involve a content change; this is not a big deal, because we shouldn't be writing to nodes in the first place if their state has not changed; and if that does ever happen the only result should be to reestablish some state that was in fact already established. https://code.launchpad.net/~fwereade/juju-core/watch-content-versions/+merge/111811 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add Version field to ContentChange #

Patch Set 3 : Add Version field to ContentChange #

Total comments: 2

Patch Set 4 : Add Version field to ContentChange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M state/watcher/watcher.go View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M state/watcher/watcher_test.go View 2 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 4
fwereade
Please take a look.
11 years, 10 months ago (2012-06-25 10:41:59 UTC) #1
fwereade
Please take a look.
11 years, 10 months ago (2012-06-27 15:10:24 UTC) #2
niemeyer
LGTM https://codereview.appspot.com/6330053/diff/5001/state/watcher/watcher.go File state/watcher/watcher.go (right): https://codereview.appspot.com/6330053/diff/5001/state/watcher/watcher.go#newcode11 state/watcher/watcher.go:11: // valid when Exists is true. // ...
11 years, 10 months ago (2012-06-28 06:21:29 UTC) #3
fwereade
11 years, 10 months ago (2012-06-28 07:37:15 UTC) #4
*** Submitted:

Add Version field to ContentChange

As discussed on IRC. One notable consequence is that the ContentWatcher now
fires on version changes that don't involve a content change; this is not
a big deal, because we shouldn't be writing to nodes in the first place if
their state has not changed; and if that does ever happen the only result
should be to reestablish some state that was in fact already established.

R=niemeyer
CC=
https://codereview.appspot.com/6330053

https://codereview.appspot.com/6330053/diff/5001/state/watcher/watcher.go
File state/watcher/watcher.go (right):

https://codereview.appspot.com/6330053/diff/5001/state/watcher/watcher.go#new...
state/watcher/watcher.go:11: // valid when Exists is true.
On 2012/06/28 06:21:30, niemeyer wrote:
> // ... Version and Content will be zeroed
> // when Exists is false.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b