Issue 6308084: Add RelationRole.CounterpartRole

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6308084: Add RelationRole.CounterpartRole

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by fwereade

Modified:
11 years, 10 months ago

Reviewers:
mp+110789

Visibility:
Public.

Description

Add RelationRole.CounterpartRole Since niemeyer said he didn't mind for now, I thought I'd propose this alone; and if/when we do turn out to need fancy new roles which don't have counterparts, we can always get rid of this, and it will still hopefully help us find the bits we need to fix if and when that happens. https://code.launchpad.net/~fwereade/juju-core/counterpart-role/+merge/110789 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add RelationRole.CounterpartRole #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -17 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/relation.go	View	3 chunks	+20 lines, -8 lines	0 comments	Download
M	state/topology.go	View	2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

11 years, 10 months ago (2012-06-18 14:34:46 UTC) #3

*** Submitted:

Add RelationRole.CounterpartRole

Since niemeyer said he didn't mind for now, I thought I'd propose this
alone; and if/when we do turn out to need fancy new roles which don't have
counterparts, we can always get rid of this, and it will still hopefully help
us find the bits we need to fix if and when that happens.

R=niemeyer
CC=
https://codereview.appspot.com/6308084

Expand All Messages | Collapse All Messages