Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6307058: code review 6307058: cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by dfc
Modified:
1 year, 10 months ago
Reviewers:
CC:
Kyle C, rsc, golang-dev
Visibility:
Public.

Description

cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin

Fixes issue 3708.

The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross
compilation on darwin using the Apple default compiler on 10.7.3.

This failure was introduced in 9b455eb64690.

This has been tested by cross compiling on darwin/amd64 to linux/arm using

* gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
* clang version 3.1 (branches/release_31)

As well as on linux/arm using

* gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
* Debian clang version 3.1-4 (branches/release_31) (based on LLVM 3.1)

Patch Set 1 #

Patch Set 2 : diff -r f33da81baac2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f33da81baac2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f33da81baac2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmd/5c/list.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/list.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5l/list.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
dfc
Hello consalus@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 10 months ago #1
Kyle C
On 2012/06/08 00:34:21, dfc wrote: > Hello mailto:consalus@gmail.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
1 year, 10 months ago #2
rsc
LGTM
1 year, 10 months ago #3
dfc
1 year, 10 months ago #4
*** Submitted as http://code.google.com/p/go/source/detail?r=432f2b7f5458 ***

cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin

Fixes issue 3708.

The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross
compilation on darwin using the Apple default compiler on 10.7.3.

This failure was introduced in 9b455eb64690.

This has been tested by cross compiling on darwin/amd64 to linux/arm using

* gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
* clang version 3.1 (branches/release_31)

As well as on linux/arm using

* gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
* Debian clang version 3.1-4 (branches/release_31) (based on LLVM 3.1)

R=consalus, rsc
CC=golang-dev
http://codereview.appspot.com/6307058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5