Code review - Issue 6307058: code review 6307058: cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure o...https://codereview.appspot.com/2012-06-08T03:13:20+00:00rietveld
Message from unknown
2012-06-07T23:45:18+00:00dfcurn:md5:bddca14fe9ea9bdb2fff286fac51897c
Message from unknown
2012-06-07T23:45:23+00:00dfcurn:md5:32b637e757b30ef09c82d8fe8b2c0daf
Message from unknown
2012-06-08T00:34:16+00:00dfcurn:md5:26c1561f9f5f848c3bb11d25400a7c3d
Message from dave@cheney.net
2012-06-08T00:34:21+00:00dfcurn:md5:505f2d82e37fd58ccbea5678ec6d364e
Hello consalus@gmail.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from consalus@gmail.com
2012-06-08T01:13:56+00:00Kyle Curn:md5:4a665b0afee00fc65e1b27bcf42e4461
On 2012/06/08 00:34:21, dfc wrote:
> Hello mailto:consalus@gmail.com (cc: mailto:golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
LGTM.
Message from rsc@golang.org
2012-06-08T02:16:04+00:00rscurn:md5:cdec4560ee164389f752f58f849d74e4
LGTM
Message from unknown
2012-06-08T03:12:55+00:00dfcurn:md5:6d7cde47025ee24e3c95ef2f4e6069d1
Message from dave@cheney.net
2012-06-08T03:13:20+00:00dfcurn:md5:ec5e39d54ef80da218e27bbada5c6156
*** Submitted as http://code.google.com/p/go/source/detail?r=432f2b7f5458 ***
cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin
Fixes issue 3708.
The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross
compilation on darwin using the Apple default compiler on 10.7.3.
This failure was introduced in 9b455eb64690.
This has been tested by cross compiling on darwin/amd64 to linux/arm using
* gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
* clang version 3.1 (branches/release_31)
As well as on linux/arm using
* gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
* Debian clang version 3.1-4 (branches/release_31) (based on LLVM 3.1)
R=consalus, rsc
CC=golang-dev
http://codereview.appspot.com/6307058