[http #96] Curl logger

Simple implementation of curl-logging. Only problem: Data requires the user to copy two seperate lines.

Example (no data):

CONFIG: curl -v --compressed -X GET -H 'Accept-Encoding: gzip' -H 'Authorization: <Not Logged>' -H 'User-Agent: Google-CalendarSample/1.0 Google-HTTP-Java-Client/1.11.0-beta-SNAPSHOT (gzip)' -- https://www.googleapis.com/calendar/v3/calendars/google.com_1uja4spq05fg4jnm5un0msqfjc@group.calendar.google.com/events

Example (data)

CONFIG: curl -v --compressed -X POST -H 'Accept-Encoding: gzip' -H 'Authorization: <Not Logged>' -H 'User-Agent: Google-CalendarSample/1.0 Google-HTTP-Java-Client/1.11.0-beta-SNAPSHOT (gzip)' -H 'Content-Type: application/json; charset=UTF-8' -d '@-' -- https://www.googleapis.com/calendar/v3/calendars/google.com_1uja4spq05fg4jnm5un0msqfjc@group.calendar.google.com/events << $$$

Jun 18, 2012 5:51:11 PM com.google.api.client.util.LoggingByteArrayOutputStream close
CONFIG: {"end":{"dateTime":"2012-06-18T22:51:11.576Z"},"start":{"dateTime":"2012-06-18T21:51:11.576Z"},"summary":"New Event"}


(user has to copy both lines, and enter an additional $$$<LF> to add the data content)

[mlinder, 2012-06-18 22:04:37]

Please review as it fits (low priority)

[yanivi, 2012-07-13 16:15:08]

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java
(right):

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:640:
if ("Authorization".equalsIgnoreCase(name)
we should also avoid "Cookie" header to match behavior of Android curl logger

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:676:
* @since 1.9
@since 1.11

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:678:
public static void serializeHeaders(HttpHeaders headers, StringBuilder logbuf,
stupid question: why even make serializeHeaders public in the first place?  why
not just package private?

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:699:
public static void serializeHeaders(HttpHeaders headers, StringBuilder logbuf,
Logger logger,
move the deprecated method to be before the non-deprecated method to minimize
the diff in this changeset

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:813:
serializeHeaders(headers, null, null, new
HeaderParsingFakeLevelHttpRequest(this, state));
call the non-deprecated one with an extra ", null"

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java
(right):

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:130:
/** Determines whether curl-logging should be enabled for this request. */
no hyphen: "curl logging"

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:410:
* Returns whether logging in form of curl-commands is enabled for this request.
no hyphen: "curl commands"

similarly below

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:867:
curlbuf = new StringBuilder("curl -v --compressed -X ");
better to remove "--compressed" in case server doesn't support compressed
commands

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:867:
curlbuf = new StringBuilder("curl -v --compressed -X ");
perhaps avoid "-X GET" in the special case of method.equals("GET")?

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:911:
if (curlbuf != null) {
"curlLoggingEnabled" instead of "curlbuf != null" just for readability

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:926:
// do not log @ curl as the user will most likely manipulate the content
can you please explain this comment?

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:930:
curlbuf.append(" -d '@-'");
please explain the '@-'

http://codereview.appspot.com/6305094/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:941:
curlbuf.append(" << $$$");
please explain this

[yanivi, 2012-07-30 22:11:34]

Obsolete.  Moved to:
http://codereview.appspot.com/6447066/