Issue 6305063: environs/ec2: fix madeBucket.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305063: environs/ec2: fix madeBucket.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+109154

Visibility:
Public.

Description

environs/ec2: fix madeBucket. Also document the fact that if an Environ is destroyed, other Environs referring to the same thing may not subsequently work. Original proposal at https://codereview.appspot.com/6255050/ https://code.launchpad.net/~rogpeppe/juju-core/go-ec2-fix-made-bucket/+merge/109154 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: fix madeBucket. #

Patch Set 3 : environs/ec2: fix madeBucket. #

Patch Set 4 : environs/ec2: fix madeBucket. #

Patch Set 5 : environs/ec2: fix madeBucket. #

Patch Set 6 : environs/ec2: fix madeBucket. #

Total comments: 2

Patch Set 7 : environs/ec2: fix madeBucket. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -2 lines)			Patch
A	[revision details]	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/export_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	environs/ec2/storage.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	environs/interface.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	environs/jujutest/tests.go	View	1 2 3 4 5 6	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/06/11 06:59:35, rog wrote: > Please take a look. LGTM. That was simple :)

11 years, 10 months ago (2012-06-11 07:03:37 UTC) #3

niemeyer

LGTM https://codereview.appspot.com/6305063/diff/6001/environs/jujutest/tests.go File environs/jujutest/tests.go (right): https://codereview.appspot.com/6305063/diff/6001/environs/jujutest/tests.go#newcode70 environs/jujutest/tests.go:70: e3 := t.Open(c) A comment explaining why we're ...

11 years, 10 months ago (2012-06-12 13:45:30 UTC) #5

rog

11 years, 10 months ago (2012-06-12 13:57:58 UTC) #6

*** Submitted:

environs/ec2: fix madeBucket.

Also document the fact that if an Environ is destroyed,
other Environs referring to the same thing may not subsequently
work.
Original proposal at https://codereview.appspot.com/6255050/

R=dfc, fwereade, niemeyer
CC=
https://codereview.appspot.com/6305063

https://codereview.appspot.com/6305063/diff/6001/environs/jujutest/tests.go
File environs/jujutest/tests.go (right):

https://codereview.appspot.com/6305063/diff/6001/environs/jujutest/tests.go#n...
environs/jujutest/tests.go:70: e3 := t.Open(c)
On 2012/06/12 13:45:30, niemeyer wrote:
> A comment explaining why we're reopening would help here.

Done.

Expand All Messages | Collapse All Messages