Issue 63040043: code review 63040043: cmd/gc: diagnose "make([]T, non-integer)" correctly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63040043: code review 63040043: cmd/gc: diagnose "make([]T, non-integer)" correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by minux1

Modified:
11 years, 4 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

cmd/gc: diagnose "make([]T, non-integer)" correctly. Fixes issue 7223.

Patch Set 2 : diff -r 1a32fe60e079 https://code.google.com/p/go #

Patch Set 3 : diff -r b604a3f0cf7b https://code.google.com/p/go #

Patch Set 4 : diff -r b604a3f0cf7b https://code.google.com/p/go #

Patch Set 5 : diff -r b604a3f0cf7b https://code.google.com/p/go #

Patch Set 6 : diff -r b604a3f0cf7b https://code.google.com/p/go #

Patch Set 7 : diff -r 1924b7e9adf5 https://code.google.com/p/go #

Patch Set 8 : diff -r 1924b7e9adf5 https://code.google.com/p/go #

Total comments: 2

Patch Set 9 : diff -r 19355fdfb5aa https://code.google.com/p/go #

Patch Set 10 : diff -r db2d9387f8c5 https://code.google.com/p/go #

Patch Set 11 : diff -r db2d9387f8c5 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -18 lines)			Patch
	M	src/cmd/gc/typecheck.c	View	1 2 3 4 5 6 7 8	1 chunk	+27 lines, -18 lines	0 comments	Download
	A	test/fixedbugs/issue7223.go	View	1 2 3 4 5 6	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-02-14 05:22:10 UTC) #1

rsc

LGTM https://codereview.appspot.com/63040043/diff/110001/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/63040043/diff/110001/src/cmd/gc/typecheck.c#newcode3234 src/cmd/gc/typecheck.c:3234: case CTINT: case CTRUNE: case CTFLT: case CTCPLX: ...

11 years, 4 months ago (2014-02-19 19:37:16 UTC) #3

minux1

*** Submitted as https://code.google.com/p/go/source/detail?r=9c9a92434303 *** cmd/gc: diagnose "make([]T, non-integer)" correctly. Fixes issue 7223. LGTM=rsc R=golang-codereviews, ...

11 years, 4 months ago (2014-02-23 21:31:53 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.

Expand All Messages | Collapse All Messages