Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 6303064: Flexible modes for node grouping operators (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by lukas.toenne
Modified:
9 years, 11 months ago
Reviewers:
bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Modification of node groups by adding/removing nodes is not possible yet. This patch extends the 'Make Group' operator and adds a new 'Separate' operator to add such functionality. 1) For inserting into existing groups: The 'Make Group from selected' (CTRL+g) operator shows a selection popup (like the object parenting operator), with options depending on the type of the active node (last selected): * "New" -> regular operator, creates new group type with all selected nodes inside. * "Insert" (only if active node is a group) -> adds all other selected nodes into the group. Currently still prohibits groups inside groups in general, though would be technically possible as long as no actual recursion occurs (group containing itself). 2) For extracting from an existing group: New 'Separate from group' operator (p), works similar to separating vertices/edges/faces from mesh. Two modes: * "Copy" makes a copy of the nodes in the parent tree, but keeps the original group intact. * "Move" removes selected nodes from the node group and adds them to the parent tree See the bf-committers mailing list for a more detailed description and rationale.

Patch Set 1 #

Patch Set 2 : Make sure the parent pointers stay valid when separating nodes from a group #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -310 lines) Patch
source/blender/blenkernel/BKE_node.h View 1 1 chunk +1 line, -3 lines 0 comments Download
source/blender/editors/space_node/node_edit.c View 1 8 chunks +617 lines, -9 lines 0 comments Download
source/blender/editors/space_node/node_intern.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/editors/space_node/node_ops.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/nodes/intern/node_common.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
source/blender/nodes/intern/node_common.c View 1 3 chunks +0 lines, -296 lines 0 comments Download

Messages

Total messages: 2
lukas.toenne
9 years, 11 months ago (2012-06-10 10:40:52 UTC) #1
lukas.toenne
9 years, 11 months ago (2012-06-11 15:36:23 UTC) #2
Make sure the parent pointers stay valid when separating nodes from a group
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b