Prevent summaries from being over long.

Prevent summaries from being over long.



https://code.launchpad.net/~niemeyer/lbox/long-summary/+merge/111099

(do not edit description out of merge proposal)

[niemeyer, 2012-06-19 20:11:31]

Please take a look.

[niemeyer, 2012-06-19 20:14:16]

*** Submitted:

Prevent summaries from being over long.

R=
CC=
https://codereview.appspot.com/6302100

[gz, 2012-06-19 20:47:14]

Thanks. Looks alright to my limited knowledge of the language (spell while loops
with 'for' huh?)

The different handling of long subject vs. no subject seems like a minor
wrinkle. Looping on Log validity instead might be neater, provided it is still
escapable. Giving a hint of how long might be nice, rather than leaving it to
trial and error for the user. (With git review I noticed I get some vim
highlight thing that changes colour at 50 characters, but that's not in scope
here.)

[niemeyer, 2012-06-19 21:19:02]

Applied your suggestions on https://codereview.appspot.com/6305112

Except for the behavior on an empty log. This is a well known way to cancel the
action on that kind of software (bzr, git, etc), and I'm keen on preserving
that.

[gz, 2012-06-19 21:37:24]

> Except for the behavior on an empty log. This is a well known way to cancel
the
> action on that kind of software (bzr, git, etc), and I'm keen on preserving
> that.

Thanks. What I was getting at is that, if I read the current logic correctly,
that the exit is triggered by an empty summary, not an empty log - for instance
a leading blank link.