environs/ec2: fixes from go vet checking

environs/ec2: fixes from go vet checking

There are also some other fixes suggested:

state/topology.go:72:2: struct field tag "relation-role" not compatible with reflect.StructTag.Get
state/topology.go:73:2: struct field tag "relation-name" not compatible with reflect.StructTag.Get
store/store.go:122:5: struct field tag "_id" not compatible with reflect.StructTag.Get
store/store.go:123:5: struct field tag "t" not compatible with reflect.StructTag.Get

I wonder if we should use the standard tag format for these
tags (`yaml:"relation-role"`).

https://code.launchpad.net/~rogpeppe/juju-core/govet-fixes/+merge/110261

(do not edit description out of merge proposal)

[rog, 2012-06-14 08:40:38]

Please take a look.

[TheMue, 2012-06-14 09:02:37]

Mostly LGTM, only one little comment. 

Thanks for the hint with the tags, I'll change it for topology.

https://codereview.appspot.com/6301080/diff/2001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/6301080/diff/2001/environs/ec2/ec2.go#newcode282
environs/ec2/ec2.go:282: return nil, fmt.Errorf("ec2: cannot find juju tools
that would work on the specified instance: %v", err)
In state we removed/are removing the prefix "state: ". So maybe here the "ec2: "
should be removed too. Additionally the errors below don't have that prefix.

[niemeyer, 2012-06-14 19:33:42]

Thanks for finding these issues Rog. LGTM

https://codereview.appspot.com/6301080/diff/2001/environs/ec2/ec2.go
File environs/ec2/ec2.go (right):

https://codereview.appspot.com/6301080/diff/2001/environs/ec2/ec2.go#newcode282
environs/ec2/ec2.go:282: return nil, fmt.Errorf("ec2: cannot find juju tools
that would work on the specified instance: %v", err)
On 2012/06/14 09:02:37, TheMue wrote:
> In state we removed/are removing the prefix "state: ". So maybe here the "ec2:
"
> should be removed too. Additionally the errors below don't have that prefix.

+1

[rog, 2012-06-19 10:45:39]

*** Submitted:

environs/ec2: fixes from go vet checking

There are also some other fixes suggested:

state/topology.go:72:2: struct field tag "relation-role" not compatible with
reflect.StructTag.Get
state/topology.go:73:2: struct field tag "relation-name" not compatible with
reflect.StructTag.Get
store/store.go:122:5: struct field tag "_id" not compatible with
reflect.StructTag.Get
store/store.go:123:5: struct field tag "t" not compatible with
reflect.StructTag.Get

I wonder if we should use the standard tag format for these
tags (`yaml:"relation-role"`).

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6301080