Issue 6300060: state: store units inside their respective services

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6300060: state: store units inside their respective services

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+109120

Visibility:
Public.

Description

state: store units inside their respective services Making this change simplifies a lot of code - no need to keep a separate sequence numbering system for units, for example. (original proposal at https://codereview.appspot.com/6247066/) https://code.launchpad.net/~rogpeppe/juju-core/go-state-units-under-service/+merge/109120 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: store units inside their respective services #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+518 lines, -619 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/internal_test.go	View		8 chunks	+322 lines, -386 lines	0 comments	Download
M	state/machine.go	View		3 chunks	+10 lines, -14 lines	0 comments	Download
M	state/service.go	View		10 chunks	+27 lines, -56 lines	0 comments	Download
M	state/state.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	state/state_test.go	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	state/topology.go	View		13 chunks	+100 lines, -126 lines	0 comments	Download
M	state/unit.go	View	1	8 chunks	+48 lines, -30 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

rog

11 years, 10 months ago (2012-06-07 12:08:12 UTC) #1

*** Submitted:

state: store units inside their respective services

Making this change simplifies a lot of code - no need
to keep a separate sequence numbering system for units,
for example.

(original proposal at https://codereview.appspot.com/6247066/)

R=
CC=
https://codereview.appspot.com/6300060

Expand All Messages | Collapse All Messages