Issue 6299082: state: implement Machine.WatchUnits

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+110101

Visibility:
Public.

Description

state: implement Machine.WatchUnits https://code.launchpad.net/~rogpeppe/juju-core/machine-units-watcher/+merge/110101 Requires: https://code.launchpad.net/~rogpeppe/juju-core/assign-subordinate-units/+merge/109885 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: implement Machine.WatchUnits #

Patch Set 3 : state: implement Machine.WatchUnits #

Total comments: 3

Patch Set 4 : state: implement Machine.WatchUnits #

Patch Set 5 : state: implement Machine.WatchUnits #

Total comments: 2

Patch Set 6 : state: implement Machine.WatchUnits #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -0 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	state/watcher.go	View	1 2 3 4 5	2 chunks	+105 lines, -0 lines	0 comments	Download
M	state/watcher_test.go	View	1 2	1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/6299082/diff/5001/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6299082/diff/5001/state/watcher.go#newcode403 state/watcher.go:403: // units are assigned or removed from a machine. ...

11 years, 10 months ago (2012-06-13 19:36:56 UTC) #3

rog

https://codereview.appspot.com/6299082/diff/5001/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6299082/diff/5001/state/watcher.go#newcode438 state/watcher.go:438: return On 2012/06/13 19:36:56, niemeyer wrote: > Please see ...

11 years, 10 months ago (2012-06-13 20:14:09 UTC) #4

niemeyer

Nice, LGTM. Just a minor: https://codereview.appspot.com/6299082/diff/3007/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6299082/diff/3007/state/watcher.go#newcode469 state/watcher.go:469: // ignore the unit ...

11 years, 10 months ago (2012-06-14 15:29:28 UTC) #6

rog

11 years, 10 months ago (2012-06-14 15:35:32 UTC) #7

*** Submitted:

state: implement Machine.WatchUnits

R=niemeyer
CC=
https://codereview.appspot.com/6299082

https://codereview.appspot.com/6299082/diff/3007/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/6299082/diff/3007/state/watcher.go#newcode469
state/watcher.go:469: // ignore the unit rather than panicing.
On 2012/06/14 15:29:29, niemeyer wrote:
> Rather than a comment, a logged message would be best here.

Done.

Expand All Messages | Collapse All Messages