Issue 6298082: Add tomb to Pinger

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6298082: Add tomb to Pinger

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by fwereade

Modified:
11 years, 11 months ago

Reviewers:
mp+110317

Visibility:
Public.

Description

Add tomb to Pinger I don't recall why we agreed that Stop/Kill should not return errors, or why I was asked not to use a tomb in the original implementation, but I'm going to need to know when a Pinger is dying soon; and this will also allow us to check pinger sanity in the unit-relation-watcher CL. https://code.launchpad.net/~fwereade/juju-core/pinger-tomb/+merge/110317 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add tomb to Pinger #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -54 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/presence/presence.go	View		3 chunks	+44 lines, -30 lines	0 comments	Download
M	state/presence/presence_test.go	View	1	12 chunks	+62 lines, -18 lines	0 comments	Download
M	state/relation_test.go	View	1	5 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2012/06/14 12:53:00, fwereade wrote: > Please take a look. LGTM

11 years, 11 months ago (2012-06-14 13:51:11 UTC) #2

niemeyer

LGTM https://codereview.appspot.com/6298082/diff/1/state/presence/presence_test.go File state/presence/presence_test.go (right): https://codereview.appspot.com/6298082/diff/1/state/presence/presence_test.go#newcode307 state/presence/presence_test.go:307: <-p.Dying() There's apparently no inverted test of Dying. ...

11 years, 11 months ago (2012-06-14 15:50:49 UTC) #3

fwereade

11 years, 11 months ago (2012-06-14 16:32:43 UTC) #4

*** Submitted:

Add tomb to Pinger

I don't recall why we agreed that Stop/Kill should not return errors, or why I
was asked not to use a tomb in the original implementation, but I'm going to
need to know when a Pinger is dying soon; and this will also allow us to check
pinger sanity in the unit-relation-watcher CL.

R=rog, niemeyer
CC=
https://codereview.appspot.com/6298082

Expand All Messages | Collapse All Messages